From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53276 invoked by alias); 10 Aug 2015 09:44:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53260 invoked by uid 89); 10 Aug 2015 09:44:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Aug 2015 09:44:12 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-27-0AbrH2ocSKi1baky4856LQ-1; Mon, 10 Aug 2015 10:44:06 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 10 Aug 2015 10:44:06 +0100 Message-ID: <55C87266.5040007@arm.com> Date: Mon, 10 Aug 2015 09:44:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Uros Bizjak CC: "gcc-patches@gcc.gnu.org" , Jeff Law , "H.J. Lu" Subject: Re: [PATCH][RTL-ifcvt] Improve conditional select ops on immediates References: <55BF666A.5000008@arm.com> <55BF6FE5.8020902@arm.com> <55BF8AAF.7060101@arm.com> <55BF8E7F.2010108@arm.com> <55BFA2DB.1040507@arm.com> <55C07B81.4070703@arm.com> <55C87093.1090307@arm.com> In-Reply-To: X-MC-Unique: 0AbrH2ocSKi1baky4856LQ-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00442.txt.bz2 On 10/08/15 10:43, Uros Bizjak wrote: > On Mon, Aug 10, 2015 at 11:36 AM, Kyrill Tkachov = wrote: > >>>>> I'm testing a patch that fix the testcases on x86_64 and does not >>>>> harm codegen on aarch64. Feel free to file a PR and assign it to me. >>>> PR67103 [1] >>>> >>>> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D67103 >>> Thanks, >>> Here's the patch to move that transformation from >>> noce_try_store_flag_constants >>> to noce_try_cmove after the target-specific expansion has had a go. >>> >>> This fixes the testcases for me on x86_64. >>> In i386.exp I only see: >>> FAIL: gcc.target/i386/pr49781-1.c scan-assembler-not lea[lq]?[ >>> \t]\\((%|)r[a-z0-9]* >>> FAIL: gcc.target/i386/pr61403.c scan-assembler blend >>> >>> which were there before my patch. >>> Bootstrap and testing on x86_64, arm and aarch64 is successful for me. >>> >>> Is this ok? >> >> Ping. >> Uros, does the codegen with this patch look ok to you? > Yes, the code of previously failing testcases looks OK. > > You will need an approval from rtl-optimization maintainer, though. Sure, thanks for confirming. Kyrill > > Uros. >