public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom de Vries <Tom_deVries@mentor.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: "gcc-patches@gnu.org" <gcc-patches@gnu.org>
Subject: Re: [RFC] Add check_effective_target_vect_min_max
Date: Wed, 12 Aug 2015 09:15:00 -0000	[thread overview]
Message-ID: <55CB0E85.3020403@mentor.com> (raw)
In-Reply-To: <yddmvxwc2k0.fsf@lokon.CeBiTec.Uni-Bielefeld.DE>

On 12/08/15 10:51, Rainer Orth wrote:
> Tom de Vries <Tom_deVries@mentor.com> writes:
>
>> This follow-up patch introduces a new effective target vect_min_max,
>> similar to how effective target vect_bswap is implemented.
>>
>> Any comments?
>>
>> Thanks,
>> - Tom
>>
>> Add check_effective_target_vect_min_max
>>
>> 2015-08-12  Tom de Vries  <tom@codesourcery.com>
>>
>> 	* lib/target-supports.exp (check_effective_target_vect_min_max): New
>> 	proc.
>> 	* gcc.dg/vect/trapv-vect-reduc-4.c: Use vect_min_max effective target.
>
> Looks good to me, but the new effective-target keyword needs documenting
> in sourcebuild.texi.
>

Hmm, in sourcebuild.texi I found:
...
@item vect_no_int_max
Target does not support a vector max instruction on @code{int}.
...

That looks related. [ I also found a patch introducing vect_no_uint_max 
here: https://gcc.gnu.org/ml/gcc-patches/2010-01/msg00152.html. ]

I'm not sure where to take it from here. Should I introduce 
vect_no_int_min, and use that in combination with vect_no_int_max?

Thanks,
- Tom

  reply	other threads:[~2015-08-12  9:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12  5:57 [committed, testsuite] Fix vect/trapv-vect-reduc-4.c for sparc Tom de Vries
2015-08-12  6:34 ` [RFC] Add check_effective_target_vect_min_max Tom de Vries
2015-08-12  8:51   ` Rainer Orth
2015-08-12  9:15     ` Tom de Vries [this message]
2015-08-12  9:18       ` Rainer Orth
2015-08-12 10:06         ` Richard Biener
2015-08-23  9:05           ` [committed] Rename vect_no_int_max to vect_no_int_min_max Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CB0E85.3020403@mentor.com \
    --to=tom_devries@mentor.com \
    --cc=gcc-patches@gnu.org \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).