public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Sidwell <nathan_sidwell@mentor.com>
To: Thomas Schwinge <thomas@codesourcery.com>,
	GCC Patches	<gcc-patches@gcc.gnu.org>
Cc: Cesar Philippidis <cesar_philippidis@mentor.com>,
	Jakub Jelinek	<jakub@redhat.com>
Subject: Re: [gomp4] Work around expand_GOACC_DIM_SIZE/expand_GOACC_DIM_POS ICEs
Date: Wed, 12 Aug 2015 12:50:00 -0000	[thread overview]
Message-ID: <55CB40F7.6020600@mentor.com> (raw)
In-Reply-To: <55CB400E.1060506@codesourcery.com>

On 08/12/15 08:46, Nathan Sidwell wrote:
> On 08/12/15 06:21, Thomas Schwinge wrote:
>> Hi!
>   OpenACC offloading code for Intel MIC doesn't make
>> a lot of sense (currently), but it is what's being done, and has caused a
>> lot of regressions in my testing, so I committed the following workaround
>> to gomp-4_0-branch in r226804.  A different approach would have been to
>> invent some machinery to not compile OpenACC offloading code on the Intel
>> MIC offloading path, but as the latter eventually is to support OpenACC
>> offloading, too (see
>
> The right solution is probably for the default validated_dims to set the size to
> unity, just like the host.  Thereby forcing any backend that wants to provide a
> larger size to override that hook.
>
> I.e. remove the #ifndef ACCEL_COMPILER from default_validate_dims in omp-low

for avoidance of doubt, I'll add that to the patch I have in progress.

nathan

-- 
Nathan Sidwell - Director, Sourcery Services - Mentor Embedded

  reply	other threads:[~2015-08-12 12:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 17:38 [gomp4] signed nums are better for dimensions Nathan Sidwell
2015-08-12 10:22 ` [gomp4] Work around expand_GOACC_DIM_SIZE/expand_GOACC_DIM_POS ICEs (was: signed nums are better for dimensions) Thomas Schwinge
2015-08-12 12:46   ` [gomp4] Work around expand_GOACC_DIM_SIZE/expand_GOACC_DIM_POS ICEs Nathan Sidwell
2015-08-12 12:50     ` Nathan Sidwell [this message]
2015-08-12 13:30       ` [gomp4] dimension API Nathan Sidwell
2015-08-12 15:49         ` Nathan Sidwell
2015-08-13  6:58         ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CB40F7.6020600@mentor.com \
    --to=nathan_sidwell@mentor.com \
    --cc=cesar_philippidis@mentor.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).