From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55082 invoked by alias); 14 Aug 2015 14:50:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 55052 invoked by uid 89); 14 Aug 2015 14:50:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 14 Aug 2015 14:50:24 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id D059F13599; Fri, 14 Aug 2015 14:50:22 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-104.phx2.redhat.com [10.3.113.104]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7EEoMAb015252; Fri, 14 Aug 2015 10:50:22 -0400 Subject: Re: [PATCH] Fix middle-end/67133, part 1 To: Marek Polacek , Richard Biener References: <20150814112006.GR3335@redhat.com> <20150814132945.GS3335@redhat.com> Cc: GCC Patches From: Jeff Law Message-ID: <55CE002E.6000108@redhat.com> Date: Fri, 14 Aug 2015 14:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150814132945.GS3335@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00795.txt.bz2 On 08/14/2015 07:29 AM, Marek Polacek wrote: > On Fri, Aug 14, 2015 at 03:14:10PM +0200, Richard Biener wrote: >> On Fri, Aug 14, 2015 at 1:20 PM, Marek Polacek wrote: >>> As outlined in the PR, this fixes one ICE. The code in question here >>> tries to determine whether OP can be derived as non-NULL. In case the >>> function has the nonnull attribute that applies to all the arguments, >>> we want to see whether OP is in this argument list. But nonnull only >>> appertains to pointers. Some ssa_names don't have a type so check for >>> that first instead of segv before looking at its tree code. >> >> Huh? All but released SSA names have a type. So this gets invoked on dead code > > I suppose so. It gets > def_stmt > > version 13 in-free-list> > > (it didn't ICE before r209891 because the operand_equal_p check came first and > returned false so we didn't check the type). Let's track this down -- nothing should be referencing anything in the SSA_NAME freelist. Jeff