From: Jeff Law <law@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix middle-end/67133, part 1
Date: Fri, 14 Aug 2015 15:39:00 -0000 [thread overview]
Message-ID: <55CE0A5A.4070802@redhat.com> (raw)
In-Reply-To: <20150814153224.GU3335@redhat.com>
On 08/14/2015 09:32 AM, Marek Polacek wrote:
> On Fri, Aug 14, 2015 at 08:50:22AM -0600, Jeff Law wrote:
>> On 08/14/2015 07:29 AM, Marek Polacek wrote:
>>> On Fri, Aug 14, 2015 at 03:14:10PM +0200, Richard Biener wrote:
>>>> On Fri, Aug 14, 2015 at 1:20 PM, Marek Polacek <polacek@redhat.com> wrote:
>>>>> As outlined in the PR, this fixes one ICE. The code in question here
>>>>> tries to determine whether OP can be derived as non-NULL. In case the
>>>>> function has the nonnull attribute that applies to all the arguments,
>>>>> we want to see whether OP is in this argument list. But nonnull only
>>>>> appertains to pointers. Some ssa_names don't have a type so check for
>>>>> that first instead of segv before looking at its tree code.
>>>>
>>>> Huh? All but released SSA names have a type. So this gets invoked on dead code
>>>
>>> I suppose so. It gets
>>> <ssa_name 0x7ffff1890948 nothrow var <var_decl 0x7ffff188df30 c>def_stmt
>>>
>>> version 13 in-free-list>
>>>
>>> (it didn't ICE before r209891 because the operand_equal_p check came first and
>>> returned false so we didn't check the type).
>> Let's track this down -- nothing should be referencing anything in the
>> SSA_NAME freelist.
>
> Ok, I'll investigate and come back to y'all when/if I find something.
Thanks. I still regret using the TREE_TYPE as a way to chain elements
in the free list:( I didn't want to add another pointer field...
jeff
next prev parent reply other threads:[~2015-08-14 15:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 11:51 Marek Polacek
2015-08-14 13:19 ` Richard Biener
2015-08-14 13:36 ` Marek Polacek
2015-08-14 14:54 ` Jeff Law
2015-08-14 15:33 ` Marek Polacek
2015-08-14 15:39 ` Jeff Law [this message]
2015-08-14 20:12 ` Marek Polacek
2015-08-14 20:36 ` Jeff Law
2015-08-14 21:48 ` Marek Polacek
2015-08-17 17:47 ` Jeff Law
2015-08-17 18:01 ` Marek Polacek
2015-08-18 8:47 ` Richard Biener
2015-08-18 20:09 ` Marek Polacek
2015-08-19 9:54 ` Richard Biener
2015-08-19 10:39 ` Marek Polacek
2015-08-19 14:25 ` Jeff Law
2015-08-20 9:05 ` Andreas Schwab
2015-08-20 10:50 ` Marek Polacek
2015-08-20 10:58 ` Andreas Schwab
2015-08-20 16:42 ` Jeff Law
2015-08-20 16:59 ` Marek Polacek
2015-08-20 16:59 ` Jeff Law
2015-08-20 17:02 ` Marek Polacek
2015-08-20 17:11 ` Jeff Law
2015-08-23 10:54 ` Jan-Benedict Glaw
2015-08-24 15:55 ` Jeff Law
2015-08-24 16:15 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CE0A5A.4070802@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).