From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-405486-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 34047 invoked by alias); 18 Aug 2015 19:23:41 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 34034 invoked by uid 89); 18 Aug 2015 19:23:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 18 Aug 2015 19:23:38 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (Postfix) with ESMTPS id 9925B32B0BF;	Tue, 18 Aug 2015 19:23:37 +0000 (UTC)
Received: from localhost.localdomain (ovpn-113-201.phx2.redhat.com [10.3.113.201])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7IJNaIC013565;	Tue, 18 Aug 2015 15:23:37 -0400
Subject: Re: [PATCH][4/N] Introduce new inline functions for GET_MODE_UNIT_SIZE and GET_MODE_UNIT_PRECISION
To: David Sherwood <david.sherwood@arm.com>,        GCC Patches <gcc-patches@gcc.gnu.org>
References: <000101d0d8e1$2c74fcd0$855ef670$@arm.com>
From: Jeff Law <law@redhat.com>
Message-ID: <55D38638.3050403@redhat.com>
Date: Tue, 18 Aug 2015 19:26:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <000101d0d8e1$2c74fcd0$855ef670$@arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg01023.txt.bz2

On 08/17/2015 05:38 AM, David Sherwood wrote:
> Hi,
>
> This is the last patch in the series. It follows on from:
>
> [PATCH][3/N] Replace the pattern GET_MODE_BITSIZE (GET_MODE_INNER (m))
> with GET_MODE_UNIT_BITSIZE (m)
>
> As a simple optimisation, introduce new inline functions for GET_MODE_UNIT_SIZE
> and GET_MODE_UNIT_PRECISION in machmode.h so that we can reduce two inline
> calls, i.e. GET_MODE_INNER and GET_MODE_SIZE, into one.
>
> Tested:
> aarch64 and aarch64_be - no regressions in gcc testsuite
> x86_64 - bootstrap build, no testsuite regressions
> arm-none-eabi - no regressions in gcc testsuite
>
> Good to go?
> David.
>
> ChangeLog:
>
> 2015-07-17  David Sherwood  <david.sherwood@arm.com>
>
>      gcc/
>          * genmodes.c (emit_mode_unit_size_inline): New function.
>          (emit_mode_unit_precision_inline): New function.
>          (emit_insn_modes_h): Emit new #define.  Emit new functions.
>          (emit_mode_unit_size): New function.
>          (emit_mode_unit_precision): New function.
>          (emit_mode_adjustments): Add mode_unit_size adjustments.
>          (emit_insn_modes_c): Emit new arrays.
>          * machmode.h (GET_MODE_UNIT_SIZE, GET_MODE_UNIT_PRECISION): Update to
>          use new inline methods.
I asked Richard S. to give this a once-over which he did.  However, he 
technically can't approve due to the way his maintainership position was 
worded.

The one request would be a function comment for emit_mode_unit_size and 
emit_mode_unit_precision.  OK with that change.

Thanks,
Jeff