From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33557 invoked by alias); 19 Aug 2015 19:33:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33540 invoked by uid 89); 19 Aug 2015 19:33:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.9 required=5.0 tests=BAYES_50,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: einhorn.in-berlin.de Received: from einhorn.in-berlin.de (HELO einhorn.in-berlin.de) (192.109.42.8) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 19 Aug 2015 19:33:35 +0000 X-Envelope-From: doko@ubuntu.com Received: from [10.0.2.2] (HSI-KBW-085-216-024-032.hsi.kabelbw.de [85.216.24.32]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-4) with ESMTP id t7JJXVLN025786 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 19 Aug 2015 21:33:31 +0200 Message-ID: <55D4DA0B.6000106@ubuntu.com> Date: Wed, 19 Aug 2015 19:37:00 -0000 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Lynn A. Boger" , gcc-patches CC: david Edelsohn , Ian Taylor , Alan Modra Subject: Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack References: <55D39752.5090602@linux.vnet.ibm.com> In-Reply-To: <55D39752.5090602@linux.vnet.ibm.com> Content-Type: multipart/mixed; boundary="------------090707020902020506040100" X-SW-Source: 2015-08/txt/msg01129.txt.bz2 This is a multi-part message in MIME format. --------------090707020902020506040100 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 2180 On 08/18/2015 10:36 PM, Lynn A. Boger wrote: > As discussed in PR 66870, for ppc64le and ppc64le it is preferred to > use the gold linker with gccgo or gcc if the split stack option is enabled. > Use of the gold linker with the split stack option results in less storage > allocated for goroutine stacks; if split stack is used without the gold > linker then some testcase failures can occur. > > Since the use of the gold linker has not been well tested > with all gcc compilers on Power, it is only used as the linker if the > split stack option is used. > > This adds the capability to the configure for gcc and libgo to determine > if the gold linker is available at build time, either in the path or explicitly > configured, and its version supports split stack. If that is the case then > defines are set that cause the gold linker to be used by the compiler when > -fsplit-stack is used. This applies to ppc64 and ppc64le. Other platforms > with split stack work as before. > > 2015-08-18 Lynn Boger > > gcc/ > PR target/66870 > config/rs6000/linux64.h: When HAVE_LD_GOLD_SUPPORTS_SPLIT_STACK > is defined add -fuse-ld=gold if fsplit-stack and not m32 > config/rs6000/sysv4.h: Define TARGET_CAN_SPLIT_STACK based on > LIBC version. > config.in: Set up HAVE_LD_GOLD_SUPPORTS_SPLIT_STACK. > configure.ac: When gold linker is available and its version > supports split stack on ppc64, ppc64le, define > HAVE_LD_GOLD_SUPPORTS_SPLIT_STACK. > configure: Regenerate. > > libgo/ > PR target/66870 > configure.ac: When gccgo for building libgo uses the gold version > containing split stack support on ppc64, ppc64le, define > LINKER_SUPPORTS_SPLIT_STACK. > configure: Regenerate. > > For platforms other than ppc64 and ppc64le, the configure for gcc > and libgo behave as before. why keep the old behaviour for other archs that have split stack support? Is it really necessary to make this dependent on the target? I'm still using an unreviewed/unpinged patch to enable gold for gccgo (attached). Matthias --------------090707020902020506040100 Content-Type: text/plain; charset=UTF-8; name="go-use-gold.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="go-use-gold.diff" Content-length: 4697 IyBEUDogUGFzcyAtZnVzZS1sZD1nb2xkIHRvIGdjY2dvIG9uIHRhcmdldHMg c3VwcG9ydGluZyAtZnNwbGl0LXN0YWNrCgpnY2MvZ28vICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgKiBn b3NwZWMuYyAobGFuZ19zcGVjaWZpY19kcml2ZXIpOiBQYXNzIC1mdXNlLWxk PWdvbGQgb24gdGFyZ2V0cyAgICAgICAgICAgICAgICAgICAgIAogICAgICAg IHN1cHBvcnRpbmcgLWZzcGxpdC1zdGFjaywgdW5sZXNzIG92ZXJ3cml0dGVu LiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg CmdjYy8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIAogICAgICAgICogY29uZmlndXJlLmFjOiBOZXcgZGVmaW5lIEhBVkVf R09MRF9OT05fREVGQVVMVC4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAKICAgICAgICAqIGNvbmZpZy5pbjogUmVnZW5lcmF0ZS4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIApJbmRleDogYi9zcmMvZ2NjL2dvL2dvc3BlYy5j Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGEvc3JjL2djYy9nby9nb3Nw ZWMuYworKysgYi9zcmMvZ2NjL2dvL2dvc3BlYy5jCkBAIC0xMTcsNiArMTE3 LDEwIEBAIGxhbmdfc3BlY2lmaWNfZHJpdmVyIChzdHJ1Y3QgY2xfZGVjb2Rl ZF8KICAgLyogV2hldGhlciB0aGUgLVMgb3B0aW9uIHdhcyB1c2VkLiAgKi8K ICAgYm9vbCBzYXdfb3B0X1MgPSBmYWxzZTsKIAorICAvKiAiLWZ1c2UtbGQ9 IiBpZiBpdCBhcHBlYXJzIG9uIHRoZSBjb21tYW5kIGxpbmUuICAqLworICBi b29sIHNhd191c2VfbGQgQVRUUklCVVRFX1VOVVNFRCA9IGZhbHNlOworICBp bnQgbmVlZF9nb2xkID0gMDsKKwogICAvKiBUaGUgZmlyc3QgaW5wdXQgZmls ZSB3aXRoIGFuIGV4dGVuc2lvbiBvZiAuZ28uICAqLwogICBjb25zdCBjaGFy ICpmaXJzdF9nb19maWxlID0gTlVMTDsgIAogCkBAIC0yMTcsNiArMjIxLDEx IEBAIGxhbmdfc3BlY2lmaWNfZHJpdmVyIChzdHJ1Y3QgY2xfZGVjb2RlZF8K IAkgICAgfQogCiAJICBicmVhazsKKworCWNhc2UgT1BUX2Z1c2VfbGRfYmZk OgorCWNhc2UgT1BUX2Z1c2VfbGRfZ29sZDoKKwkgIHNhd191c2VfbGQgPSB0 cnVlOworCSAgYnJlYWs7CiAJfQogICAgIH0KIApAQCAtMjI2LDggKzIzNSwx NCBAQCBsYW5nX3NwZWNpZmljX2RyaXZlciAoc3RydWN0IGNsX2RlY29kZWRf CiAgIHNoYXJlZF9saWJnY2MgPSAwOwogI2VuZGlmCiAKKyNpZiBkZWZpbmVk KFRBUkdFVF9DQU5fU1BMSVRfU1RBQ0spICYmIGRlZmluZWQoSEFWRV9HT0xE X05PTl9ERUZBVUxUKQorICBpZiAoIXNhd191c2VfbGQpCisgICAgbmVlZF9n b2xkID0gMTsKKyNlbmRpZgorCiAgIC8qIE1ha2Ugc3VyZSB0byBoYXZlIHJv b20gZm9yIHRoZSB0cmFpbGluZyBOVUxMIGFyZ3VtZW50LiAgKi8KLSAgbnVt X2FyZ3MgPSBhcmdjICsgbmVlZF9tYXRoICsgc2hhcmVkX2xpYmdjYyArIChs aWJyYXJ5ID4gMCkgKiA1ICsgMTA7CisgIG51bV9hcmdzID0gYXJnYyArIG5l ZWRfbWF0aCArIHNoYXJlZF9saWJnY2MgKyBuZWVkX2dvbGQgKworICAgIChs aWJyYXJ5ID4gMCkgKiA1ICsgMTA7CiAgIG5ld19kZWNvZGVkX29wdGlvbnMg PSBYTkVXVkVDIChzdHJ1Y3QgY2xfZGVjb2RlZF9vcHRpb24sIG51bV9hcmdz KTsKIAogICBpID0gMDsKQEAgLTI0NCw2ICsyNTksMTQgQEAgbGFuZ19zcGVj aWZpY19kcml2ZXIgKHN0cnVjdCBjbF9kZWNvZGVkXwogCQkgICAgICAgJm5l d19kZWNvZGVkX29wdGlvbnNbal0pOwogICAgICAgaisrOwogICAgIH0KKyNp ZmRlZiBIQVZFX0dPTERfTk9OX0RFRkFVTFQKKyAgaWYgKG5lZWRfZ29sZCkK KyAgICB7CisgICAgICBnZW5lcmF0ZV9vcHRpb24gKE9QVF9mdXNlX2xkX2dv bGQsIE5VTEwsIDEsIENMX0RSSVZFUiwKKwkJICAgICAgICZuZXdfZGVjb2Rl ZF9vcHRpb25zW2pdKTsKKyAgICAgIGorKzsKKyAgICB9CisjZW5kaWYKICNl bmRpZgogCiAgIC8qIE5PVEU6IFdlIHN0YXJ0IGF0IDEgbm93LCBub3QgMC4g ICovCkluZGV4OiBiL3NyYy9nY2MvY29uZmlnLmluCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGEvc3JjL2djYy9jb25maWcuaW4KKysrIGIvc3JjL2dj Yy9jb25maWcuaW4KQEAgLTEyNzcsNiArMTI3NywxMiBAQAogI2VuZGlmCiAK IAorLyogRGVmaW5lIGlmIHRoZSBnb2xkIGxpbmtlciBpcyBhdmFpbGFibGUg YXMgYSBub24tZGVmYXVsdCAqLworI2lmbmRlZiBVU0VEX0ZPUl9UQVJHRVQK KyN1bmRlZiBIQVZFX0dPTERfTk9OX0RFRkFVTFQKKyNlbmRpZgorCisKIC8q IERlZmluZSBpZiB5b3UgaGF2ZSB0aGUgaWNvbnYoKSBmdW5jdGlvbi4gKi8K ICNpZm5kZWYgVVNFRF9GT1JfVEFSR0VUCiAjdW5kZWYgSEFWRV9JQ09OVgpJ bmRleDogYi9zcmMvZ2NjL2NvbmZpZ3VyZS5hYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBhL3NyYy9nY2MvY29uZmlndXJlLmFjCisrKyBiL3NyYy9n Y2MvY29uZmlndXJlLmFjCkBAIC0yMjI1LDYgKzIyMjUsMTIgQEAgaWYgdGVz dCB4JGdjY19jdl9sZCAhPSB4OyB0aGVuCiBmaQogQUNfTVNHX1JFU1VMVCgk bGRfaXNfZ29sZCkKIAorIyBDaGVjayB0byBzZWUgaWYgbGQgaXMgdXNlZCwg YW5kIGdvbGQgaXMgYXZhaWxhYmxlCitpZiB0ZXN0IHgkbGRfaXNfZ29sZCA9 IHhubyAmJiB3aGljaCAke2djY19jdl9sZH0uZ29sZCA+L2Rldi9udWxsIDI+ JjE7IHRoZW4KKyAgQUNfREVGSU5FKEhBVkVfR09MRF9OT05fREVGQVVMVCwg MSwKKyAgCSAgICBbRGVmaW5lIGlmIHRoZSBnb2xkIGxpbmtlciBpcyBhdmFp bGFibGUgYXMgYSBub24tZGVmYXVsdF0pCitmaQorCiBPUklHSU5BTF9MRF9G T1JfVEFSR0VUPSRnY2NfY3ZfbGQKIEFDX1NVQlNUKE9SSUdJTkFMX0xEX0ZP Ul9UQVJHRVQpCiBjYXNlICIkT1JJR0lOQUxfTERfRk9SX1RBUkdFVCIgaW4K --------------090707020902020506040100--