From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22039 invoked by alias); 19 Aug 2015 22:07:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21890 invoked by uid 89); 19 Aug 2015 22:07:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 19 Aug 2015 22:07:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 3151F4C641; Wed, 19 Aug 2015 22:07:27 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-201.phx2.redhat.com [10.3.113.201]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7JM7QgX024186; Wed, 19 Aug 2015 18:07:26 -0400 Subject: Re: [PING] Re: [PATCH] New configure option to default enable Smart Stack Protection To: Magnus Granberg , gcc-patches@gcc.gnu.org References: <39898046.VMObuEqk0e@laptop1.gw.ume.nu> <3383748.JHYIIDZpVP@laptop1.gw.ume.nu> <1924864.DoOlOdAJp4@laptop1.gw.ume.nu> From: Jeff Law Message-ID: <55D4FE1E.2080207@redhat.com> Date: Wed, 19 Aug 2015 22:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1924864.DoOlOdAJp4@laptop1.gw.ume.nu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01144.txt.bz2 On 07/13/2015 07:20 AM, Magnus Granberg wrote: > Patch updated and tested on x86_64-unknown-linux-gnu (Gentoo) > > Changlogs > /gcc > 2015-07-05 Magnus Granberg > > * common.opt (fstack-protector): Initialize to -1. > (fstack-protector-all): Likewise. > (fstack-protector-strong): Likewise. > (fstack-protector-explicit): Likewise. > * configure.ac: Add --enable-default-ssp. > * defaults.h (DEFAULT_FLAG_SSP): New. Default SSP to strong. > * opts.c (finish_options): Update opts->x_flag_stack_protect if it is -1. > * doc/install.texi: Document --enable-default-ssp. > * config.in: Regenerated. > * configure: Likewise. > > /testsuite > 2015-07-13 Magnus Granberg > > * lib/target-supports.exp > (check_effective_target_fstack_protector_enabled): New test. > * gcc.target/i386/ssp-default.c: New test. Sorry for the delay, it seems nobody picked this up. It's a nit, but the feature is "Stack Smashing Protection", not "Smart Stack Protection". I'll fix that nit and install your change. Thanks! Jeff