From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38559 invoked by alias); 20 Aug 2015 14:38:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38550 invoked by uid 89); 20 Aug 2015 14:38:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_50,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mx07-00178001.pphosted.com Received: from mx08-00178001.pphosted.com (HELO mx07-00178001.pphosted.com) (91.207.212.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 20 Aug 2015 14:37:59 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.14.5/8.14.5) with SMTP id t7KEWrpj025915; Thu, 20 Aug 2015 16:37:52 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 1wcafx9k2y-1 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 20 Aug 2015 16:37:52 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C29E131; Thu, 20 Aug 2015 14:37:42 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas6.st.com [10.75.90.73]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 42B015525; Thu, 20 Aug 2015 14:37:50 +0000 (GMT) Received: from [164.129.122.197] (164.129.122.197) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.389.2; Thu, 20 Aug 2015 16:37:49 +0200 Message-ID: <55D5E293.9070003@st.com> Date: Thu, 20 Aug 2015 14:57:00 -0000 From: Christian Bruel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Kyrill Tkachov , "msebor@redhat.com" , "ramana.radhakrishnan@foss.arm.com" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH testsuite, ARM] skip Wno-frame-address tests References: <55D5D9E4.2050806@st.com> <55D5DAC9.6070001@arm.com> In-Reply-To: <55D5DAC9.6070001@arm.com> X-No-Archive: yes Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-20_07:2015-08-20,2015-08-20,1970-01-01 signatures=0 X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01208.txt.bz2 On 08/20/2015 03:48 PM, Kyrill Tkachov wrote: > Hi Christian, > > On 20/08/15 14:45, Christian Bruel wrote: >> Hello, >> >> 2 tests from rev 226480 introduced a new failure for ARM testing -Werror >> because a warning is always emitted regardless -Wframe-address is given >> or not. >> >> From expand_builtin_frame_address: >> >> /* Some ports cannot access arbitrary stack frames. */ >> if (tem == NULL) >> { >> warning (0, "unsupported argument to %qD", fndecl); >> return const0_rtx; >> } >> >> This patch just skips the test on ARM that can't access arbitrary stack >> frame anyway and will always warn. >> >> OK for trunk ? thanks, >> >> Christian >> >> >> >> >> >> >> >> no-frame-address.patch >> >> >> 015-08-20 Christian Bruel >> >> * gcc.dg/Wno-frame-address.c: Skip for ARM. >> * g++.dg/Wno-frame-address.C: Ditto. >> >> Index: gcc/testsuite/gcc.dg/Wno-frame-address.c >> =================================================================== >> --- gcc/testsuite/gcc.dg/Wno-frame-address.c (revision 227030) >> +++ gcc/testsuite/gcc.dg/Wno-frame-address.c (working copy) >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-skip-if "Cannot access arbitrary stack frames. " { arm*-*-* } { "*" } { "" } } */ >> /* { dg-options "-Werror" } */ >> >> /* Verify that -Wframe-address is not enabled by default by enabling >> Index: gcc/testsuite/g++.dg/Wno-frame-address.C >> =================================================================== >> --- gcc/testsuite/g++.dg/Wno-frame-address.C (revision 227030) >> +++ gcc/testsuite/g++.dg/Wno-frame-address.C (working copy) >> @@ -1,4 +1,5 @@ >> // { dg-do compile } >> +/* { dg-skip-if "Cannot access arbitrary stack frames. " { arm*-*-* } { "*" } { "" } } */ >> // { dg-options "-Werror" } > > Use the C++-style comment here. oops yes. cut and pasted. > Otherwise looks ok to me, though if more tests like this crop we'd want a > dg-requires-effective-target check that filters out the targets that don't > implement this feature. agree, if more targets come up with the same failure a predicate helper will be useful. thanks Christian > > Kyrill > >> >> // Verify that -Wframe-address is not enabled by default by enabling >