From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99221 invoked by alias); 21 Aug 2015 16:13:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99207 invoked by uid 89); 21 Aug 2015 16:13:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 21 Aug 2015 16:13:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id E186791EAC; Fri, 21 Aug 2015 16:13:41 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-201.phx2.redhat.com [10.3.113.201]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7LGDfAn024625; Fri, 21 Aug 2015 12:13:41 -0400 Subject: Re: Fix PR debug/66728 To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: <87io88920k.fsf@e105548-lin.cambridge.arm.com> From: Jeff Law Message-ID: <55D74E35.7010005@redhat.com> Date: Fri, 21 Aug 2015 16:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <87io88920k.fsf@e105548-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01326.txt.bz2 On 08/21/2015 07:58 AM, Richard Sandiford wrote: > This is yet another bug caused by rtx having modeless scalar integer > constants. We need to use context to find the actual mode of a > CONST_INT or CONST_WIDE_INT. We've been bumping into these as long as I can remember. I suspect I still have a great essay from Jim on why it's hard to fix on a hard drive from one of my old HP boxes from the early 90s ;-) > gcc/ > PR debug/66728 > * dwarf2out.c (loc_descriptor): Remove redundant GET_MODE of > CONST_WIDE_INTs. Handle BLKmode for CONST_WIDE_INT too. > (add_const_value_attribute): Add a mode parameter. > Check it for CONST_INT and CONST_WIDE_INT. Use it to build > wide_int values. > (add_location_or_const_value_attribute): Update call. > (tree_add_const_value_attribute): Likewise. I'll have to defer to Jason & Jakub on this. Note Jakub is on PTO right now. jeff