From: Pedro Alves <palves@redhat.com>
To: Yaakov Selkowitz <yselkowi@redhat.com>,
gcc-patches@gcc.gnu.org,
"binutils@sourceware.org" <binutils@sourceware.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] config: fix AM_ICONV for in-tree libiconv
Date: Sat, 22 Aug 2015 21:38:00 -0000 [thread overview]
Message-ID: <55D8ABBA.3090208@redhat.com> (raw)
In-Reply-To: <1432934749.13692.9.camel@redhat.com>
On 05/29/2015 10:25 PM, Yaakov Selkowitz wrote:
> This is the second in a series of patches to make a build with an
> in-tree GNU libiconv work as designed.
>
> Currently GDB is the only toolchain component which actually uses an
> in-tree libiconv. This patch modifies the common AM_ICONV to use an
> in-tree libiconv when present and not already provided by libc. (GDB's
> workaround uses an in-tree libiconv even when libc provides iconv(3);
> I'm not sure when or why that would be desirable.)
>
> Once these two patches are merged in to each tree, I will follow with
> patches to regenerate the various configure scripts and a few other
> minor corresponding changes.
I noticed that regenerating binutils/configure or gdb/configure
undoes the libiconv changes done here:
commit 016a3251631341bf4d8fe50966d2b70f8ea69e96
Author: DJ Delorie <dj@redhat.com>
AuthorDate: Thu Aug 6 18:35:26 2015 -0400
Commit: DJ Delorie <dj@redhat.com>
CommitDate: Thu Aug 6 23:55:06 2015 -0400
Yaakov Selkowitz: fixes for in-tree libiconv
* Makefile.def (libiconv): Define bootstrap=true.
Mark pdf/html/info as missing.
(configure-gcc): Depend on all-libiconv.
(all-gcc): Ditto.
(configure-libcpp): Ditto.
(all-libcpp): Ditto.
(configure-intl): Ditto.
(all-intl): Ditto.
* Makefile.in: Regenerate.
binutils/
* configure: Regenerate.
gdb/
* Makefile.in (LIBICONV): Define.
(CLIBS): Add LIBICONV.
* acinclude.m4: Use config/iconv.m4 instead of custom AM_ICONV.
* configure: Regenerate.
However, that commit does not include any config/iconv.m4/AM_ICONV
change. Looks like you forgot to attach the config/iconv.m4 patch, and
then only the regeneration bits were pushed (both binutils-gdb git
and gcc svn)?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-08-22 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 22:09 Yaakov Selkowitz
2015-07-01 20:46 ` Yaakov Selkowitz
2015-07-01 20:52 ` Yaakov Selkowitz
2015-07-01 20:53 ` Yaakov Selkowitz
2015-07-01 20:53 ` Yaakov Selkowitz
2015-08-22 21:38 ` Pedro Alves [this message]
2015-08-23 19:53 ` Yaakov Selkowitz
2015-08-24 10:51 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D8ABBA.3090208@redhat.com \
--to=palves@redhat.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yselkowi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).