From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18785 invoked by alias); 25 Aug 2015 21:44:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18776 invoked by uid 89); 25 Aug 2015 21:44:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 25 Aug 2015 21:44:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 3F95A341AE6; Tue, 25 Aug 2015 21:44:03 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-93.phx2.redhat.com [10.3.113.93]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7PLi2cB010826; Tue, 25 Aug 2015 17:44:02 -0400 Subject: Re: [PATCH 2/5] completely_scalarize arrays as well as records To: Alan Lawrence , gcc-patches@gcc.gnu.org, rguenther@suse.de References: <1440500777-25966-1-git-send-email-alan.lawrence@arm.com> <1440500777-25966-3-git-send-email-alan.lawrence@arm.com> <20150825214232.GB12831@virgil.suse.cz> From: Jeff Law Message-ID: <55DCE1A2.7050501@redhat.com> Date: Tue, 25 Aug 2015 21:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150825214232.GB12831@virgil.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01560.txt.bz2 On 08/25/2015 03:42 PM, Martin Jambor wrote: > Hi, > > On Tue, Aug 25, 2015 at 12:06:14PM +0100, Alan Lawrence wrote: >> This changes the completely_scalarize_record path to also work on arrays (thus >> allowing records containing arrays, etc.). This just required extending the >> existing type_consists_of_records_p and completely_scalarize_record methods >> to handle things of ARRAY_TYPE as well as RECORD_TYPE. Hence, I renamed both >> methods so as not to mention 'record'. > > thanks for working on this. I see Jeff has already approved the > patch, but I have two comments nevertheless. First, I would be much > happier if you added a proper comment to scalarize_elem function which > you forgot completely. The name is not very descriptive and it has > quite few parameters too. Right. I mentioned that I missed the lack of function comments when looking at #3 and asked Alan to go back and fix them in #1 and #2. > > Second, this patch should also fix PR 67283. It would be great if you > could verify that and add it to the changelog when committing if that > is indeed the case. Excellent. Yes, definitely mention the BZ. jeff