From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-406223-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 40017 invoked by alias); 28 Aug 2015 02:12:00 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 40005 invoked by uid 89); 28 Aug 2015 02:11:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 28 Aug 2015 02:11:58 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (Postfix) with ESMTPS id 29E4E3B3C6;	Fri, 28 Aug 2015 02:11:57 +0000 (UTC)
Received: from [10.10.116.36] (ovpn-116-36.rdu2.redhat.com [10.10.116.36])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7S2BrQ4010130;	Thu, 27 Aug 2015 22:11:54 -0400
Subject: Re: C++ delayed folding branch review
To: Kai Tietz <ktietz70@googlemail.com>
References: <557A5214.7060106@redhat.com> <CAEwic4ZQomb_en7o4=n40j8cHU6-TXmhoSOZZOshiw1Pkgi0Bg@mail.gmail.com> <CAEwic4YufFNkdjaXxW0e1ExaGJk0xWwT8FJfiekJWa_mzVsxOQ@mail.gmail.com> <55B911DD.30105@redhat.com> <CAEwic4Z-MgOwdyY_GTP+hGrK6qHgRoys8d4Tj_kHMri7oGuqHQ@mail.gmail.com> <55BA5667.9040200@redhat.com> <CAEwic4apQgQzSWU6Rbyn-OnBqTu_ADrCm-2Fsc2iPsm_NhUr_g@mail.gmail.com> <55BAACF9.7040707@redhat.com> <597173047.4338388.1438379666336.JavaMail.zimbra@redhat.com> <55BEE4CE.9070706@redhat.com> <CAEwic4aQeu6c88q+RfZ=mGu6tObjzq9tWR4YgRnxCjk2PG=cXQ@mail.gmail.com> <55BF8B2B.9040001@redhat.com> <CAEwic4aN=BVPQkg03u257v=wRc1j5G4e91ahf0g4BBfhUUyhMg@mail.gmail.com> <55DE7C55.6030207@redhat.com> <CAEwic4ZoKOnXi2oMoJXFsr-e+duL0KtwJ22WBTN7DGcwX3A8qg@mail.gmail.com> <55DF1042.9020603@redhat.com> <CAEwic4Z5X0BTV1-S3M77uree3+E8KgLLwESaTjZT-j8E5FmTyA@mail.gmail.com> <CAEwic4YJkbKPTs5t4fE08xZQ3QuUi_eqA_b+3N_46p8S9v3Ddg@mail.gmail.com>
Cc: Kai Tietz <ktietz@redhat.com>, gcc-patches List <gcc-patches@gcc.gnu.org>
From: Jason Merrill <jason@redhat.com>
Message-ID: <55DFC368.3050108@redhat.com>
Date: Fri, 28 Aug 2015 03:03:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <CAEwic4YJkbKPTs5t4fE08xZQ3QuUi_eqA_b+3N_46p8S9v3Ddg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-08/txt/msg01760.txt.bz2

On 08/27/2015 02:12 PM, Kai Tietz wrote:
> +  else if (TREE_CODE (type) == VECTOR_TYPE)
> +    {
> +      if (TREE_CODE (arg1) == VECTOR_CST
> +         && code == NOP_EXPR
> +         && TYPE_VECTOR_SUBPARTS (type) == VECTOR_CST_NELTS (arg1))
> +       {
> +         tree r = copy_node (arg1);
> +         TREE_TYPE (arg1) = type;
> +         return r;
> +       }
> +    }

I would drop the check on 'code' and add a check that

  TYPE_MAIN_VARIANT (type) == TYPE_MAIN_VARIANT (TREE_TYPE (arg1))

Does that still pass?

Jason