From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54346 invoked by alias); 28 Aug 2015 14:00:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54336 invoked by uid 89); 28 Aug 2015 14:00:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Aug 2015 14:00:34 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-2-U11qLv0xTJa1DO8BNm2ccA-1; Fri, 28 Aug 2015 15:00:30 +0100 Received: from [10.2.207.65] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 28 Aug 2015 15:00:29 +0100 Message-ID: <55E0697D.2010008@arm.com> Date: Fri, 28 Aug 2015 14:05:00 -0000 From: Alan Lawrence User-Agent: Thunderbird 2.0.0.24 (X11/20101213) MIME-Version: 1.0 To: Richard Biener CC: Christophe Lyon , "martin.jambor@suse.cz" , "gcc-patches@gcc.gnu.org" , Jeff Law Subject: Re: [PATCH 2/5] completely_scalarize arrays as well as records References: <20150825214232.GB12831@virgil.suse.cz> <1440690217-24461-1-git-send-email-alan.lawrence@arm.com> <55E03315.7080205@arm.com> In-Reply-To: X-MC-Unique: U11qLv0xTJa1DO8BNm2ccA-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01786.txt.bz2 Richard Biener wrote: > On Fri, 28 Aug 2015, Alan Lawrence wrote: >=20 >> Christophe Lyon wrote: >>> I asked because I assumed that Alan saw it pass in his configuration. >> >> Bah. No - I now discover a problem in my C++ testsuite setup that was ca= using >> a large number of tests to not be executed. I see the problem too now, >> investigating.... >=20 > Btw, your patch broke Ada: >=20 > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3DGNAT BUG=20 > DETECTED=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D+ > | 6.0.0 20150828 (experimental) (x86_64-pc-linux-gnu) GCC error:=20=20=20= =20=20=20=20=20=20=20=20 > | > | in completely_scalarize, at tree-sra.c:996=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 > | > | Error detected around ../rts/a-coorse.ads:46:24=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 > | >=20 > case ARRAY_TYPE: > { > tree elemtype =3D TREE_TYPE (decl_type); > tree elem_size =3D TYPE_SIZE (elemtype); > gcc_assert (elem_size && tree_fits_uhwi_p (elem_size)); > int el_size =3D tree_to_uhwi (elem_size); > gcc_assert (el_size); >=20 > tree minidx =3D TYPE_MIN_VALUE (TYPE_DOMAIN (decl_type)); > tree maxidx =3D TYPE_MAX_VALUE (TYPE_DOMAIN (decl_type)); > gcc_assert (TREE_CODE (minidx) =3D=3D INTEGER_CST > && TREE_CODE (maxidx) =3D=3D INTEGER_CST); >=20 > obviously you missed VLAs. min/max value can also be NULL. >=20 > Richard. >=20 Right. I think VLA's are the problem with pr64312.C also. I'm testing a fix= =20 (that declares arrays with any of these properties as unscalarizable). Monday is a bank holiday in UK and so I expect to get back to you on Tuesda= y. --Alan