From: Jason Merrill <jason@redhat.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2] Fix c++/67371 (issues with throw in constexpr)
Date: Sat, 29 Aug 2015 13:20:00 -0000 [thread overview]
Message-ID: <55E1AEDD.90807@redhat.com> (raw)
In-Reply-To: <20150829101410.GA421@x4>
On 08/29/2015 06:14 AM, Markus Trippelsdorf wrote:
> + if (integer_nonzerop (IF_COND (t)) && !RECUR (THEN_CLAUSE (t), any))
> + return false;
> + if (integer_zerop (IF_COND (t)) && !RECUR (ELSE_CLAUSE (t), any))
> + return false;
Actually, I think we can remove the IF_STMT code entirely and move the
case label to the COND_EXPR case.
Also, please add a comment explaining why we aren't checking
SWITCH_STMT_BODY.
Jason
next prev parent reply other threads:[~2015-08-29 13:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 12:25 [PATCH] " Markus Trippelsdorf
2015-08-29 3:44 ` Jason Merrill
2015-08-29 10:53 ` [PATCH v2] " Markus Trippelsdorf
2015-08-29 12:57 ` Markus Trippelsdorf
2015-08-29 13:20 ` Jason Merrill [this message]
2015-08-29 15:26 ` [PATCH v3] " Markus Trippelsdorf
2015-08-30 1:04 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E1AEDD.90807@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).