From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126054 invoked by alias); 31 Aug 2015 11:41:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126043 invoked by uid 89); 31 Aug 2015 11:41:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 31 Aug 2015 11:41:32 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZWNSq-0002TU-Cc from Tom_deVries@mentor.com ; Mon, 31 Aug 2015 04:41:28 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Mon, 31 Aug 2015 12:41:26 +0100 Message-ID: <55E43D5D.5020300@mentor.com> Date: Mon, 31 Aug 2015 11:44:00 -0000 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Jakub Jelinek CC: GCC Patches Subject: Re: [PR65637] Fix ssa-handling code in expand_omp_for_static_chunk References: <552E6341.4040401@mentor.com> In-Reply-To: <552E6341.4040401@mentor.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg01868.txt.bz2 On 15/04/15 15:10, Tom de Vries wrote: > Hi, > > This patch series fixes PR65637. > > Currently, ssa-handling code in expand_omp_for_static_chunk is dead and > not exercised by testing. > > Ssa-handling code in omp-low.c is only triggered by > pass_parallelize_loops, and that pass doesn't specify a chunk size on > the GIMPLE_OMP_FOR it constructs, so that only exercises the > expand_omp_for_static_nochunk path. > > Using the attached trigger patch, we excercise the ssa-handling code in > expand_omp_for_static_chunk. > > 1. Fix gcc_assert in expand_omp_for_static_chunk > 2. Fix inner loop phi in expand_omp_for_static_chunk > 3. Handle 2 preds for fin_bb in expand_omp_for_static_chunk I'm posting an updated series. 1. Add param parloops-chunk-size 2. Handle simple latch bb in expand_omp_for_static_chunk 3. Fix gcc_assert in expand_omp_for_static_chunk 4. Fix inner loop phi in expand_omp_for_static_chunk 5. Handle 2 preds for fin_bb in expand_omp_for_static_chunk There are two new patches, (1) and (2) in the new numbering. The first patch adds a param parloops-chunk-size, which means the ssa-handling code in expand_omp_for_static_chunk is no longer dead. The second patch handles simple latches in expand_omp_for_static_chunk, similar to the fix for PR66846 in expand_omp_for_static_nochunk. The rest of the patches are now updated to include the testcases (and patch number 4 has been updated to handle simple latches). The patch series has been bootstrapped and reg-tested on x86_64. I'll post the patches from the patch series individually. The first two in response to this email, the latter three in response to the earlier submissions. Thanks, - Tom