public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Sidwell <nathan@acm.org>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [gomp4]minor libgomp cleanup
Date: Mon, 31 Aug 2015 20:00:00 -0000	[thread overview]
Message-ID: <55E4B1D5.607@acm.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

In excising shared_size, I stumbled upon this bit of strangeness.  Attaching a 
new node onto the end of a singly linked list is not complicated ...

nathan

[-- Attachment #2: gomp4-cleanup.patch --]
[-- Type: text/x-patch, Size: 603 bytes --]

2015-08-31  Nathan Sidwell  <nathan@codesourcery.com>

	* oacc-parallel.c (GOACC_register_static): Remove superfluous NULL
	check.

Index: libgomp/oacc-parallel.c
===================================================================
--- libgomp/oacc-parallel.c	(revision 227353)
+++ libgomp/oacc-parallel.c	(working copy)
@@ -673,12 +661,9 @@ GOACC_register_static (void *addr, int s
   s->size = (size_t) size;
   s->mask = mask;
   s->free = false;
-  s->next = NULL;
-
-  if (oacc_statics)
-    s->next = oacc_statics;
+  s->next = oacc_statics;
 
-   oacc_statics = s;
+  oacc_statics = s;
 }
 
 void

                 reply	other threads:[~2015-08-31 19:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E4B1D5.607@acm.org \
    --to=nathan@acm.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).