From: Tom de Vries <Tom_deVries@mentor.com>
To: Cesar Philippidis <cesar@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Nathan Sidwell <nathan_sidwell@mentor.com>,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: [gomp4] New reduction infrastructure for OpenACC
Date: Tue, 01 Sep 2015 12:53:00 -0000 [thread overview]
Message-ID: <55E59FBA.1010005@mentor.com> (raw)
In-Reply-To: <55D4DC16.7020106@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On 19/08/15 21:42, Cesar Philippidis wrote:
> +DEFHOOK
> +(reduction,
> +"This hook is used by the oacc_transform pass to expand calls to the\n\
> +internal functions @var{GOACC_REDUCTION_SETUP},\n\
> +@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ @var{call} is gimple statement containing the call to the function. This\n\ hook removes statement @var{call} after the expanded sequence has been\n\ inserted. This hook is also responsible for allocating any storage for\n\ reductions when necessary. It returns @var{true} if the expanded\n\
> +sequence introduces any calls to OpenACC-specific internal functions.",
> +bool, (gimple call),
> +default_goacc_reduction)
> +
This causes a gomp-4_0-branch bootstrap error:
...
src/gcc/target.def:1685:1: error: unknown escape sequence: '\040' [-Werror]
...
Currently testing attached patch, which allows 'make build/genhooks.o'
to succeed.
Thanks,
- Tom
[-- Attachment #2: fix-target-def-reduction.patch --]
[-- Type: text/x-patch, Size: 1268 bytes --]
--- gcc/target.def 2015-09-01 01:45:41.851372425 -0700
+++ gcc/target.def 2015-09-01 05:41:48.280961137 -0700
@@ -1684,7 +1684,13 @@
(reduction,
"This hook is used by the oacc_transform pass to expand calls to the\n\
internal functions @var{GOACC_REDUCTION_SETUP},\n\
-@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ @var{call} is gimple statement containing the call to the function. This\n\ hook removes statement @var{call} after the expanded sequence has been\n\ inserted. This hook is also responsible for allocating any storage for\n\ reductions when necessary. It returns @var{true} if the expanded\n\
+@var{GOACC_REDUCTION_INIT},\n\
+@var{GOACC_REDUCTION_FINI} and\n\
+@var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\
+@var{call} is gimple statement containing the call to the function. This\n\
+hook removes statement @var{call} after the expanded sequence has been\n\
+inserted. This hook is also responsible for allocating any storage for\n\
+reductions when necessary. It returns @var{true} if the expanded\n\
sequence introduces any calls to OpenACC-specific internal functions.",
bool, (gimple call),
default_goacc_reduction)
next prev parent reply other threads:[~2015-09-01 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 19:43 Cesar Philippidis
[not found] ` <55D61EE2.4030402@acm.org>
2015-08-20 20:21 ` Nathan Sidwell
2015-09-01 12:53 ` Tom de Vries [this message]
2015-09-01 16:23 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E59FBA.1010005@mentor.com \
--to=tom_devries@mentor.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nathan_sidwell@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).