From: Jeff Law <law@redhat.com>
To: "Iyer, Balaji V" <balaji.v.iyer@intel.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "Zamyatin, Igor" <igor.zamyatin@intel.com>
Subject: Re: [PATCH] PR 60586
Date: Wed, 02 Sep 2015 20:58:00 -0000 [thread overview]
Message-ID: <55E76259.8090601@redhat.com> (raw)
In-Reply-To: <BF230D13CA30DD48930C31D4099330003B0F1015@fmsmsx101.amr.corp.intel.com>
On 09/01/2015 10:30 PM, Iyer, Balaji V wrote:
> Hi Jeff,
> I thought about this for a minute and I don't think I need to use the lang_hooks. I could do this change right before calling gimplify_cilk_spawn. I have attached the fixed patch and have answered your questions below. Here are the ChangeLog entries:
>
> gcc/c-family/ChangeLog:
> 2015-09-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
>
> PR middle-end/60586
> * c-common.h (cilk_gimplify_call_params_in_spawned_fn): New prototype.
> * c-gimplify.c (c_gimplify_expr): Added a call to the function
> cilk_gimplify_call_params_in_spawned_fn.
> * cilk.c (cilk_gimplify_call_params_in_spawned_fn): New function.
> (gimplify_cilk_spawn): Removed EXPR_STMT and CLEANUP_POINT_EXPR
> unwrapping.
>
> gcc/cp/ChangeLog
> 2015-09-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
>
> PR middle-end/60586
> * cp-gimplify.c (cilk_cp_gimplify_call_params_in_spawned_fn): New
> function.
> (cp_gimplify_expr): Added a call to the function
> cilk_cp_gimplify_call_params_in_spawned_fn.
>
> gcc/testsuite/ChangeLog
> 2015-09-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
>
> PR middle-end/60586
> * c-c++-common/cilk-plus/CK/pr60586.c: New file.
> * g++.dg/cilk-plus/CK/pr60586.cc: Likewise.
>
> Is this OK for trunk?
Yes. Please install.
Thanks,
Jeff
prev parent reply other threads:[~2015-09-02 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 0:05 Iyer, Balaji V
2015-09-01 22:26 ` Jeff Law
2015-09-02 1:16 ` Iyer, Balaji V
2015-09-02 1:22 ` Iyer, Balaji V
2015-09-02 4:30 ` Iyer, Balaji V
2015-09-02 20:58 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E76259.8090601@redhat.com \
--to=law@redhat.com \
--cc=balaji.v.iyer@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=igor.zamyatin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).