From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102184 invoked by alias); 2 Sep 2015 20:55:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102172 invoked by uid 89); 2 Sep 2015 20:55:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 02 Sep 2015 20:55:56 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id D339BA8F; Wed, 2 Sep 2015 20:55:54 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-93.phx2.redhat.com [10.3.113.93]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t82KtsVJ005728; Wed, 2 Sep 2015 16:55:54 -0400 Subject: Re: [PATCH] PR 60586 To: "Iyer, Balaji V" , "gcc-patches@gcc.gnu.org" References: <55E62613.7060706@redhat.com> Cc: "Zamyatin, Igor" From: Jeff Law Message-ID: <55E76259.8090601@redhat.com> Date: Wed, 02 Sep 2015 20:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00192.txt.bz2 On 09/01/2015 10:30 PM, Iyer, Balaji V wrote: > Hi Jeff, > I thought about this for a minute and I don't think I need to use the lang_hooks. I could do this change right before calling gimplify_cilk_spawn. I have attached the fixed patch and have answered your questions below. Here are the ChangeLog entries: > > gcc/c-family/ChangeLog: > 2015-09-01 Balaji V. Iyer > > PR middle-end/60586 > * c-common.h (cilk_gimplify_call_params_in_spawned_fn): New prototype. > * c-gimplify.c (c_gimplify_expr): Added a call to the function > cilk_gimplify_call_params_in_spawned_fn. > * cilk.c (cilk_gimplify_call_params_in_spawned_fn): New function. > (gimplify_cilk_spawn): Removed EXPR_STMT and CLEANUP_POINT_EXPR > unwrapping. > > gcc/cp/ChangeLog > 2015-09-01 Balaji V. Iyer > > PR middle-end/60586 > * cp-gimplify.c (cilk_cp_gimplify_call_params_in_spawned_fn): New > function. > (cp_gimplify_expr): Added a call to the function > cilk_cp_gimplify_call_params_in_spawned_fn. > > gcc/testsuite/ChangeLog > 2015-09-01 Balaji V. Iyer > > PR middle-end/60586 > * c-c++-common/cilk-plus/CK/pr60586.c: New file. > * g++.dg/cilk-plus/CK/pr60586.cc: Likewise. > > Is this OK for trunk? Yes. Please install. Thanks, Jeff