From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/3] [gomp] Add thread attribute customization
Date: Thu, 03 Sep 2015 11:43:00 -0000 [thread overview]
Message-ID: <55E830C3.5070704@embedded-brains.de> (raw)
In-Reply-To: <20150903111050.GU1847@tucnak.redhat.com>
On 03/09/15 13:10, Jakub Jelinek wrote:
> On Thu, Sep 03, 2015 at 01:09:23PM +0200, Sebastian Huber wrote:
>>>>> We have only thread attributes in this function: mutable_attr and attr. The
>>>>> attr is initialized with &gomp_thread_attr and gomp_thread_attr is supposed
>>>>> to be read-only by this function. Under certain conditions we have to modify
>>>>> the initial attributes. Since gomp_thread_attr is read-only, we have to copy
>>>>> it and then modify the copy. For this we need some storage: mutable_attr.
>>> So use local_thread_attr if you want to stress it, but IMHO thread_attr
>>> just just fine. I really don't like mutable_attr.
>> Ok, if I don't rename thread_attr, is the patch ok?
> Yes.
Thanks a lot for your kind review.
I committed the patches as:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227439
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227440
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227441
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227442
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
next prev parent reply other threads:[~2015-09-03 11:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 11:06 [PATCH 1/3] [gomp] Add RTEMS configuration Sebastian Huber
2015-07-28 11:05 ` [PATCH 2/3] [gomp] Thread pool management Sebastian Huber
2015-09-03 10:19 ` Jakub Jelinek
2015-07-28 11:13 ` [PATCH 3/3] [gomp] Add thread attribute customization Sebastian Huber
2015-09-03 10:57 ` Jakub Jelinek
2015-09-03 10:58 ` Sebastian Huber
2015-09-03 11:09 ` Jakub Jelinek
2015-09-03 11:10 ` Sebastian Huber
2015-09-03 11:12 ` Jakub Jelinek
2015-09-03 11:43 ` Sebastian Huber [this message]
2015-09-03 16:25 ` Jakub Jelinek
2015-09-03 9:48 ` [PATCH 1/3] [gomp] Add RTEMS configuration Jakub Jelinek
2015-09-03 10:02 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E830C3.5070704@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).