public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Yury Gribov <y.gribov@samsung.com>
To: Jonathan Roelofs <jonathan@codesourcery.com>,
	Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, kcc@google.com,
	Mike Stump <mrs@gcc.gnu.org>,
	Maxim Ostapenko <m.ostapenko@partner.samsung.com>
Subject: Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics.
Date: Fri, 04 Sep 2015 06:26:00 -0000	[thread overview]
Message-ID: <55E93837.1080206@samsung.com> (raw)
In-Reply-To: <55E8792A.8010909@codesourcery.com>

On 09/03/2015 07:45 PM, Jonathan Roelofs wrote:
>
>
> On 9/3/15 10:17 AM, Jakub Jelinek wrote:
>> On Thu, Sep 03, 2015 at 10:15:02AM -0600, Jonathan Roelofs wrote:
>>> +kcc, mrs
>>>
>>> Ping
>>>
>>> On 8/27/15 4:44 PM, Jonathan Roelofs wrote:
>>>> The attached patch makes the ubsan tests agnostic to ansi escape codes
>>>> in their diagnostic output.
>>
>> It wouldn't hurt if you explained in detail what is the problem you are
>> trying to solve and why something that works for most people doesn't
>> work in
>> your case.
>
> Hi Jakub,
>
> AFAICT, there are two ways to suppress the emission of color codes from
> ubsan's diagnostics:
>
>    1) Set an environment variable.
>    2) Make the output stream not a tty.
>
> #1 doesn't seem to be possible in DejaGnu without hacks.

AFAIR it can't be done for remote targets due to DejaGnu design limitations.

> #2 doesn't work in our environment because DejaGnu attempts to make
> itself appear to the program under test as if it were a tty. This might
> be an artifact of the fact that all of our testing is remote testing
> (though that is just blind speculation on my part:

AFAIK that's indeed the case.

Added Max.

-Y

  parent reply	other threads:[~2015-09-04  6:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 23:09 Jonathan Roelofs
2015-09-03 16:16 ` Jonathan Roelofs
2015-09-03 16:18   ` Jakub Jelinek
2015-09-03 16:54     ` Jonathan Roelofs
2015-09-03 17:33       ` Jonathan Roelofs
2015-09-04  6:26       ` Yury Gribov [this message]
2015-09-08 22:16         ` Jonathan Roelofs
2015-09-09  9:10           ` Maxim Ostapenko
2015-09-09 15:20       ` Mike Stump
2015-09-09 15:28         ` Andrew Pinski
2015-09-09 21:23           ` Jonathan Roelofs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E93837.1080206@samsung.com \
    --to=y.gribov@samsung.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=jonathan@codesourcery.com \
    --cc=kcc@google.com \
    --cc=m.ostapenko@partner.samsung.com \
    --cc=mrs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).