From: Jeff Law <law@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: Fix reload1.c warning for some targets
Date: Fri, 04 Sep 2015 20:16:00 -0000 [thread overview]
Message-ID: <55E9F965.8030401@redhat.com> (raw)
In-Reply-To: <87lhcn6gn4.fsf@e105548-lin.cambridge.arm.com>
On 09/03/2015 02:39 AM, Richard Sandiford wrote:
>
> It sounds like Jeff has a much more radical rewrite in mind,
Certainly not anything on the immediate horizon. The amount of block
copying that'd be needed to isolate the jump threading path would be
significant.
I do wonder if we should be looking at a way to mark paths which have
jump threading opportunities, but which we do not optimize and exploit
that information in the uninit and other analysis.
Bodik had a paper on those concepts as well. He was mostly looking at
how to account for those paths in code coverage analysis, but there may
be something useful in there.
> so for now how about just turning -Wmaybe-uninitialized into
> a warning for this function? The patch will mean that it becomes
> a warning even if someone turns off warnings on the command line,
> but I don't think that's important.
>
> Bootstrapped and regression-tested on x86_64-linux-gnu. Also tested
> with a cross-compiler to sparc-linux-gnu (which also triggered the
> warning for me). Tested that clang could still compile the file.
> OK to install?
>
>
> gcc/
> * reload1.c (elimination_costs_in_insn): Locally turn
> -Wmaybe-uninitialized into a warning.
I can live with this. Though I'd appreciate it if someone could reduce
the sparcv9 testcase and create a bug to track it too.
jeff
next prev parent reply other threads:[~2015-09-04 20:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 14:18 Richard Sandiford
2015-08-05 17:01 ` Jeff Law
2015-08-05 17:33 ` Richard Sandiford
2015-08-11 20:05 ` Jeff Law
2015-08-12 17:17 ` Jeff Law
2015-08-13 20:33 ` Richard Sandiford
2015-08-13 21:08 ` Jeff Law
2015-08-24 11:05 ` Rainer Orth
2015-09-03 8:50 ` Richard Sandiford
2015-09-04 20:16 ` Jeff Law [this message]
2015-09-10 19:33 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E9F965.8030401@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).