From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>,
Richard Biener <rguenther@suse.de>,
Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org, Ilya Verbin <iverbin@gmail.com>
Subject: Re: [PATCH] -fopenmp-simd LTO ICE fix (PR middle-end/67452)
Date: Fri, 04 Sep 2015 20:42:00 -0000 [thread overview]
Message-ID: <55EA000A.2020600@redhat.com> (raw)
In-Reply-To: <20150904152727.GL1847@tucnak.redhat.com>
On 09/04/2015 09:27 AM, Jakub Jelinek wrote:
> Hi!
>
> This patch is a fix for gomp4.1 branch ICEs on
> FAIL libgomp.c/for-5.c
> FAIL libgomp.c++/for-13.C
> that can be reproduced with intelmic emul offloading even on the trunk
> with the attached testcase. The problem is that LTO streaming doesn't
> really like earlier unreferenced VAR_DECLs to be streamed late during
> output_function (from output_cfg).
>
> The patch fixes it by clearing loop->simduid when optimizations removed
> all IL uses of the var and remove_unused_locals is about to nuke it from
> cfun->local_decls.
>
> Ok for trunk/5.3 if it passes bootstrap/regtest?
>
> 2015-09-04 Jakub Jelinek <jakub@redhat.com>
>
> PR middle-end/67452
> * tree-ssa-live.c: Include cfgloop.h.
> (remove_unused_locals): Clear loop->simduid if simduid is about
> to be removed from cfun->local_decls.
>
> * gcc.dg/lto/pr67452_0.c: New test.
OK.
jeff
prev parent reply other threads:[~2015-09-04 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 16:09 Jakub Jelinek
2015-09-04 19:24 ` Richard Biener
2015-09-04 20:42 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EA000A.2020600@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=iverbin@gmail.com \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).