From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-406899-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 130444 invoked by alias); 8 Sep 2015 15:03:27 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 130432 invoked by uid 89); 8 Sep 2015 15:03:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Sep 2015 15:03:26 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (Postfix) with ESMTPS id 3CEEA91C19;	Tue,  8 Sep 2015 15:03:25 +0000 (UTC)
Received: from localhost.localdomain (ovpn-113-28.phx2.redhat.com [10.3.113.28])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t88F3OnA017769;	Tue, 8 Sep 2015 11:03:24 -0400
Subject: Re: [PATCH] Fix seq_cost prototype to use signed int
To: Jiong Wang <jiong.wang@arm.com>,        gcc-patches List <gcc-patches@gcc.gnu.org>
References: <n994mj585o1.fsf@arm.com>
From: Jeff Law <law@redhat.com>
Message-ID: <55EEF8BC.7040608@redhat.com>
Date: Tue, 08 Sep 2015 15:03:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <n994mj585o1.fsf@arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-09/txt/msg00524.txt.bz2

On 09/08/2015 06:17 AM, Jiong Wang wrote:
>
> All other cost helper functions are using signed int to hold cost
> while seq_cost is using unsigned int.
>
> This fix this. bootstrap OK on x86.
>
> OK for trunk?
>
> 2015-09-08  Jiong Wang  <jiong.wang@arm.com>
>
> gcc/
>    * rtl.h (seq_cost): Change return type from "unsigned" to "int".
>    * rtlanal.c (seq_cost): Likewise.
Why not go the other way and start making things unsigned -- for a cost 
function like this, unsigned seems more natural to me.

jeff