From: Chung-Lin Tang <cltang@codesourcery.com>
To: Cesar Philippidis <cesar@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Nathan Sidwell <nathan_sidwell@mentor.com>
Subject: Re: [gomp4] force global locks for nvptx targets
Date: Wed, 09 Sep 2015 08:08:00 -0000 [thread overview]
Message-ID: <55EFE89C.50504@codesourcery.com> (raw)
In-Reply-To: <55EF3ED2.9090104@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On 2015/9/9 04:02 AM, Cesar Philippidis wrote:
> This patch forces GOACC_LOCK to use locks in global memory regardless if
> the lock us for a worker or a gang. We were using a shared memory for
> worker locks, but we ran into an issue with that would sporadically
> involve deadlocks in worker reductions. We're still investigating that
> issue, but for the time being, global locks appear to work albeit with a
> lock contention penalty.
>
> I've applied this patch to gomp-4_0-branch.
>
> Cesar
>
Fixed typo, committed as obvious.
Chung-Lin
2015-09-09 Chung-Lin Tang <cltang@codesourcery.com>
* config/nvptx/nvptx.c (nvptx_xform_lock): Correct typo
of variable 'force_global_locks'.
[-- Attachment #2: a.diff --]
[-- Type: text/plain, Size: 486 bytes --]
Index: config/nvptx/nvptx.c
===================================================================
--- config/nvptx/nvptx.c (revision 227582)
+++ config/nvptx/nvptx.c (working copy)
@@ -3744,7 +3744,7 @@ nvptx_xform_lock (gimple stmt, const int *ARG_UNUS
return mode > GOMP_DIM_WORKER;
case IFN_GOACC_LOCK_INIT:
- return force_global_lock || mode != GOMP_DIM_WORKER;
+ return force_global_locks || mode != GOMP_DIM_WORKER;
default: gcc_unreachable();
}
prev parent reply other threads:[~2015-09-09 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 20:09 Cesar Philippidis
2015-09-09 8:08 ` Chung-Lin Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EFE89C.50504@codesourcery.com \
--to=cltang@codesourcery.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan_sidwell@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).