From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 539 invoked by alias); 9 Sep 2015 08:53:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 516 invoked by uid 89); 9 Sep 2015 08:53:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mailout3.w1.samsung.com Received: from mailout3.w1.samsung.com (HELO mailout3.w1.samsung.com) (210.118.77.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 09 Sep 2015 08:53:44 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NUE00LL9JDF6790@mailout3.w1.samsung.com>; Wed, 09 Sep 2015 09:53:39 +0100 (BST) Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id A8.AA.05269.393FFE55; Wed, 9 Sep 2015 09:53:39 +0100 (BST) Received: from [106.109.128.167] by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NUE00L5TJDFQV00@eusync2.samsung.com>; Wed, 09 Sep 2015 09:53:39 +0100 (BST) Subject: Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics. To: Jonathan Roelofs References: <55DF92B6.6020802@codesourcery.com> <55E87206.6030500@codesourcery.com> <20150903161711.GY1847@tucnak.redhat.com> <55E8792A.8010909@codesourcery.com> <55E93837.1080206@samsung.com> <55EF5E04.1030408@codesourcery.com> Cc: Yury Gribov , Jakub Jelinek , gcc-patches@gcc.gnu.org, kcc@google.com, Mike Stump From: Maxim Ostapenko Message-id: <55EFF38F.4050203@partner.samsung.com> Date: Wed, 09 Sep 2015 09:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <55EF5E04.1030408@codesourcery.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00574.txt.bz2 On 09/09/15 01:15, Jonathan Roelofs wrote: > > > On 9/4/15 12:20 AM, Yury Gribov wrote: >> On 09/03/2015 07:45 PM, Jonathan Roelofs wrote: >>> >>> >>> On 9/3/15 10:17 AM, Jakub Jelinek wrote: >>>> On Thu, Sep 03, 2015 at 10:15:02AM -0600, Jonathan Roelofs wrote: >>>>> +kcc, mrs >>>>> >>>>> Ping >>>>> >>>>> On 8/27/15 4:44 PM, Jonathan Roelofs wrote: >>>>>> The attached patch makes the ubsan tests agnostic to ansi escape >>>>>> codes >>>>>> in their diagnostic output. >>>> >>>> It wouldn't hurt if you explained in detail what is the problem you >>>> are >>>> trying to solve and why something that works for most people doesn't >>>> work in >>>> your case. >>> >>> Hi Jakub, >>> >>> AFAICT, there are two ways to suppress the emission of color codes from >>> ubsan's diagnostics: >>> >>> 1) Set an environment variable. >>> 2) Make the output stream not a tty. >>> >>> #1 doesn't seem to be possible in DejaGnu without hacks. >> >> AFAIR it can't be done for remote targets due to DejaGnu design >> limitations. >> >>> #2 doesn't work in our environment because DejaGnu attempts to make >>> itself appear to the program under test as if it were a tty. This might >>> be an artifact of the fact that all of our testing is remote testing >>> (though that is just blind speculation on my part: >> >> AFAIK that's indeed the case. >> >> Added Max. > > I've created another patch to address the same issue in the tsan > tests, here: [1]. > > > Cheers, > > Jon > > 1: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00556.html > Jon, I've tried to apply your patch on top of trunk to test on my remote arm board and got some conflicts: gcc/testsuite/c-c++-common/ubsan/align-7.c.rej gcc/testsuite/c-c++-common/ubsan/pr63802.c.rej gcc/testsuite/c-c++-common/ubsan/overflow-int128.c.rej gcc/testsuite/c-c++-common/ubsan/align-6.c.rej The last UBSan tests adjustments were performed by Marek in r222878, perhaps your GCC doesn't include these changes? -Maxim