From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9976 invoked by alias); 9 Sep 2015 10:31:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9962 invoked by uid 89); 9 Sep 2015 10:31:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Sep 2015 10:31:30 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-14-5wGtdQjoRuK7Ut6Va5b4HA-1; Wed, 09 Sep 2015 11:31:26 +0100 Received: from e105915-lin.cambridge.arm.com ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 9 Sep 2015 11:31:25 +0100 Subject: Re: [AArch64] Fix vcvt_high_f64_f32 and vcvt_figh_f32_f64 intrinsics. To: James Greenhalgh , "gcc-patches@gcc.gnu.org" References: <1441787488-19661-1-git-send-email-james.greenhalgh@arm.com> Cc: "christophe.lyon@linaro.org" , Marcus Shawcroft , Tejas Belagod From: Alan Lawrence Message-ID: <55F00A7E.9020005@arm.com> Date: Wed, 09 Sep 2015 11:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441787488-19661-1-git-send-email-james.greenhalgh@arm.com> X-MC-Unique: 5wGtdQjoRuK7Ut6Va5b4HA-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00578.txt.bz2 Hmmm, hang on. I'm not quite sure what the actual issue/bug is here, but is= this=20 the same issue as my patch 12 "with BE RTL fix"?=20 (https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01482.html, explanation last= at=20 https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02365.html) I pushed this as= =20 r227551 last night and since this reparameterizes the patterns I don't thin= k=20 your patch will apply to current HEAD. If my patch is wrong...well, that may be, I haven't understood the issue ye= t.=20 But it sounds like the first thing we need is a decent testcase? (Or is the= =20 confusion just in the RTL representation, so a testcase would require getti= ng=20 constant-folding to happen in RTL, which I tried but failed to make that ha= ppen=20 myself?) --Alan On 09/09/15 09:31, James Greenhalgh wrote: > > Hi, > > This patch clears up some remaining confusion in the vector lane orderings > for the two intrinsics mentioned in the title. > > Bootstrapped on aarch64-none-linux-gnu and regression tested for > aarch64_be-none-elf with no issues. > > OK? > > Thanks, > James > > --- > 2015-09-09 James Greenhalgh > > * config/aarch64/aarch64-simd.md (vec_unpacks_lo_v4sf): Rewrite > as an expand. > (vec_unpacks_hi_v4sf): Likewise. > (aarch64_float_extend_lo_v2df): Rename to... > (aarch64_fcvtl_v4sf): This. > (aarch64_fcvtl2_v4sf): New. > (aarch64_float_truncate_hi_v4sf): Rewrite as an expand. > (aarch64_float_truncate_hi_v4sf_le): New. > (aarch64_float_truncate_hi_v4sf_be): Likewise. >