From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1601 invoked by alias); 9 Sep 2015 16:39:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1586 invoked by uid 89); 9 Sep 2015 16:39:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KAM_ASCII_DIVIDERS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Sep 2015 16:39:54 +0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t89GdpVe004378 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Sep 2015 16:39:52 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t89GdpTw031795 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 9 Sep 2015 16:39:51 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t89GdoCX020417; Wed, 9 Sep 2015 16:39:50 GMT Received: from [192.168.1.4] (/87.10.208.171) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 Sep 2015 09:39:50 -0700 To: "gcc-patches@gcc.gnu.org" Cc: Jason Merrill From: Paolo Carlini Subject: [C++ Patch] PR 67318 ("[6 regression] Parsing error when using abbreviated integral type names in template parameter pack declaration") Message-ID: <55F060D3.4070208@oracle.com> Date: Wed, 09 Sep 2015 16:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040901010505050003020907" X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00601.txt.bz2 This is a multi-part message in MIME format. --------------040901010505050003020907 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 922 Hi, I tracked down this regression to r225621, a clean up committed by Jason a while ago: unless we want to try something more aggressive, we can fix it the regression by simply restoring a few lines in cp_parser_template_parameter which consume the ellipsis. To clarify implementation-wise, the types affected are essentially all those for which cp_parser_simple_type_specifier (thus cp_parser_parameter_declaration) doesn't set the type in decl_specs: if (decl_specs && (token->keyword != RID_SIGNED && token->keyword != RID_UNSIGNED && token->keyword != RID_SHORT && token->keyword != RID_LONG)) cp_parser_set_decl_spec_type (decl_specs, type, token, /*type_definition_p=*/false); Weird that we didn't have any testcase! Tested x86_64-linux. Thanks, Paolo. ///////////////////////// --------------040901010505050003020907 Content-Type: text/plain; charset=UTF-8; name="CL_67318" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="CL_67318" Content-length: 440 L2NwCjIwMTUtMDktMDkgIFBhb2xvIENhcmxpbmkgIDxwYW9sby5jYXJsaW5p QG9yYWNsZS5jb20+CgoJUFIgYysrLzY3MzE4CgkqIHBhcnNlci5jIChjcF9w YXJzZXJfdGVtcGxhdGVfcGFyYW1ldGVyKTogUmV2ZXJ0IGEgZmV3IGxpbmVz IG9mCglyMjI1NjIxOiBjb25zdW1lIHRoZSBlbGxpcHNpcyBhbmQgc2V0ICpp c19wYXJhbWV0ZXJfcGFjayB0byB0cnVlLgoKL3Rlc3RzdWl0ZQoyMDE1LTA5 LTA5ICBQYW9sbyBDYXJsaW5pICA8cGFvbG8uY2FybGluaUBvcmFjbGUuY29t PgoKCVBSIGMrKy82NzMxOAoJKiBnKysuZGcvY3BwMHgvdmFyaWFkaWMxNjYu QzogTmV3Lgo= --------------040901010505050003020907 Content-Type: text/plain; charset=UTF-8; name="patch_67318" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch_67318" Content-length: 1932 SW5kZXg6IGNwL3BhcnNlci5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGNwL3BhcnNlci5jCShyZXZpc2lvbiAyMjc1ODYpCisrKyBjcC9wYXJzZXIu Ywkod29ya2luZyBjb3B5KQpAQCAtMTM4MTEsNiArMTM4MTEsMjAgQEAgY3Bf cGFyc2VyX3RlbXBsYXRlX3BhcmFtZXRlciAoY3BfcGFyc2VyKiBwYXJzZXIs IGIKIAkvKiBDb25zdW1lIHRoZSBgLi4uJyBmb3IgYmV0dGVyIGVycm9yIHJl Y292ZXJ5LiAgKi8KIAljcF9sZXhlcl9jb25zdW1lX3Rva2VuIChwYXJzZXIt PmxleGVyKTsKICAgICB9CisgIC8qIElmIHRoZSBuZXh0IHRva2VuIGlzIGFu IGVsbGlwc2lzLCBhbmQgd2UgZG9uJ3QgYWxyZWFkeSBoYXZlIGl0CisgICAg IG1hcmtlZCBhcyBhIHBhcmFtZXRlciBwYWNrLCB0aGVuIHdlIGhhdmUgYSBw YXJhbWV0ZXIgcGFjayAodGhhdAorICAgICBoYXMgbm8gZGVjbGFyYXRvciku ICAqLworICBlbHNlIGlmICghKmlzX3BhcmFtZXRlcl9wYWNrCisJICAgJiYg Y3BfbGV4ZXJfbmV4dF90b2tlbl9pcyAocGFyc2VyLT5sZXhlciwgQ1BQX0VM TElQU0lTKQorCSAgICYmIChkZWNsYXJhdG9yX2Nhbl9iZV9wYXJhbWV0ZXJf cGFjaworCSAgICAgICAocGFyYW1ldGVyX2RlY2xhcmF0b3ItPmRlY2xhcmF0 b3IpKSkKKyAgICB7CisgICAgICAvKiBDb25zdW1lIHRoZSBgLi4uJy4gICov CisgICAgICBjcF9sZXhlcl9jb25zdW1lX3Rva2VuIChwYXJzZXItPmxleGVy KTsKKyAgICAgIG1heWJlX3dhcm5fdmFyaWFkaWNfdGVtcGxhdGVzICgpOwor ICAgICAgCisgICAgICAqaXNfcGFyYW1ldGVyX3BhY2sgPSB0cnVlOworICAg IH0KIAogICAvLyBUaGUgcGFyYW1ldGVyIG1heSBoYXZlIGJlZW4gY29uc3Ry YWluZWQuCiAgIGlmIChpc19jb25zdHJhaW5lZF9wYXJhbWV0ZXIgKHBhcmFt ZXRlcl9kZWNsYXJhdG9yKSkKSW5kZXg6IHRlc3RzdWl0ZS9nKysuZGcvY3Bw MHgvdmFyaWFkaWMxNjYuQwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0 ZXN0c3VpdGUvZysrLmRnL2NwcDB4L3ZhcmlhZGljMTY2LkMJKHJldmlzaW9u IDApCisrKyB0ZXN0c3VpdGUvZysrLmRnL2NwcDB4L3ZhcmlhZGljMTY2LkMJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNCBAQAorLy8gUFIgYysrLzY3 MzE4CisvLyB7IGRnLWRvIGNvbXBpbGUgeyB0YXJnZXQgYysrMTEgfSB9CisK K3RlbXBsYXRlPHNpZ25lZC4uLj4KK3N0cnVjdCBNeVN0cnVjdDE7CisKK3Rl bXBsYXRlPHVuc2lnbmVkLi4uPgorc3RydWN0IE15U3RydWN0MjsKKwordGVt cGxhdGU8c2hvcnQuLi4+CitzdHJ1Y3QgTXlTdHJ1Y3QzOworCit0ZW1wbGF0 ZTxsb25nLi4uPgorc3RydWN0IE15U3RydWN0NDsK --------------040901010505050003020907--