From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45758 invoked by alias); 9 Sep 2015 21:31:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 45737 invoked by uid 89); 9 Sep 2015 21:31:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Sep 2015 21:31:49 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 24AC8A2C0D; Wed, 9 Sep 2015 21:31:48 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-28.phx2.redhat.com [10.3.113.28]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t89LVlqh028133; Wed, 9 Sep 2015 17:31:47 -0400 Subject: Re: [PATCH] Propagate -fdiagnostics-* options in lto-wrapper To: Chung-Lin Tang , gcc-patches References: <55EC0E15.3080008@codesourcery.com> Cc: Nathan Sidwell From: Jeff Law Message-ID: <55F0A543.6030306@redhat.com> Date: Wed, 09 Sep 2015 21:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55EC0E15.3080008@codesourcery.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00620.txt.bz2 On 09/06/2015 03:57 AM, Chung-Lin Tang wrote: > Hi, > Currently most non-target specific options are skipped when crossing the > LTO/offload processing border, however since there are still quite a > number of warning calls in many target backends, it makes sense to > save and propagate the associated options, to preserve consistency in warning > behavior. > > For example, currently: > $ x86_64-pc-linux-gnu-gcc -fopenacc test.c -fno-diagnostics-show-caret > y.c: In function 'main._omp_fn.0': > y.c:6:11: warning: using num_workers (32), ignoring 500 > #pragma acc parallel num_workers(500) > ^ > (note: this warning message is triggered by nvptx code currently only > on gomp-4_0-branch, but illustrates the point) > > The caret stills shows, because -fno-diagnostics-show-caret does not > reach the accel compiler. -flto should also have a similar issue. > > The attached patch allows a series of -fdiagnostics-* options to be > propagated by lto-wrapper. I've tested this patch without regressions, > is this okay for trunk? > > Thanks, > Chung-Lin > > 2015-09-06 Chung-Lin Tang > > * lto-wrapper.c (merge_and_complain): Add OPT_fdiagnostics_show_caret, > OPT_fdiagnostics_show_option, OPT_fdiagnostics_show_location_, and > OPT_fshow_column to handled saved option cases. > (append_compiler_options): Do not skip the above added options. OK. Please install. Thanks, Jeff