From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38658 invoked by alias); 15 Sep 2015 10:05:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38642 invoked by uid 89); 15 Sep 2015 10:05:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mx07-00178001.pphosted.com Received: from mx07-00178001.pphosted.com (HELO mx07-00178001.pphosted.com) (62.209.51.94) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 15 Sep 2015 10:05:41 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by m0046037.ppops.net (8.14.5/8.14.5) with SMTP id t8FA2kcR020891; Tue, 15 Sep 2015 12:05:36 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by m0046037.ppops.net with ESMTP id 1wxe1rhcr7-1 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 15 Sep 2015 12:05:36 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3B2E031; Tue, 15 Sep 2015 10:05:22 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas4.st.com [10.75.90.69]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0A58216103; Tue, 15 Sep 2015 10:05:35 +0000 (GMT) Received: from [164.129.122.197] (164.129.122.197) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.342.0; Tue, 15 Sep 2015 12:05:34 +0200 Subject: Re: [PATCH 4/4] [ARM] Add attribute/pragma target fpu= To: Bernhard Reutner-Fischer , "kyrylo.tkachov@arm.com" , "Ramana.Radhakrishnan@arm.com" References: <55F6D9FF.4030600@st.com> <7D8D22F4-ECEA-4BB6-A72E-2136C84EE981@gmail.com> CC: "gcc-patches@gcc.gnu.org" From: Christian Bruel X-No-Archive: yes Message-ID: <55F7ED6E.2080201@st.com> Date: Tue, 15 Sep 2015 10:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <7D8D22F4-ECEA-4BB6-A72E-2136C84EE981@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-09-15_04:2015-09-14,2015-09-15,1970-01-01 signatures=0 X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg01038.txt.bz2 On 09/14/2015 09:44 PM, Bernhard Reutner-Fischer wrote: > On September 14, 2015 4:30:23 PM GMT+02:00, Christian Bruel wrote: >> Finally, the final part of the patch set does the attribute target >> parsing and checking, redefines the preprocessor macros and implements >> the inlining rules. >> >> testcases and documentation included. > > @@ -29501,6 +29532,8 @@ > static bool > arm_valid_target_attribute_rec (tree args, struct gcc_options *opts) > { > + int ret=true; > + > if (TREE_CODE (args) == TREE_LIST) > { > bool ret = true; > > > Doesn't the hunk above trigger a shadow warning? Furthermore there are missing spaces before and after the '='. And finally (no diff -p so I can only guess) why the int if the function returns a bool? > no warning with -Wall, but nevertheless I agree this is a piece of remnant code that had to be removed. thanks