From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29794 invoked by alias); 15 Sep 2015 13:33:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28461 invoked by uid 89); 15 Sep 2015 13:33:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Sep 2015 13:33:43 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id BFC40C0B2B4B; Tue, 15 Sep 2015 13:33:41 +0000 (UTC) Received: from [10.10.116.16] (ovpn-116-16.rdu2.redhat.com [10.10.116.16]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8FDXeLm005938; Tue, 15 Sep 2015 09:33:40 -0400 Subject: Re: [C++] Coding rule enforcement To: Richard Biener , Nathan Sidwell References: <55F816F2.5010209@acm.org> Cc: GCC Patches From: Jason Merrill Message-ID: <55F81E34.3020903@redhat.com> Date: Tue, 15 Sep 2015 13:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg01075.txt.bz2 On 09/15/2015 09:26 AM, Richard Biener wrote: > Wouldn't warning flags be better so you can decide whether it's an error > or a warning via -Werror=virtual-inheritance vs. -Wvirtual-inheritance? Yep. That also handles the system header exemption (unless -Wsystem-headers). Jason