From: Christian Bruel <christian.bruel@st.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, ARM] Clean up arm_option_params_internals macro settings for attribute/pragma targets
Date: Wed, 16 Sep 2015 07:10:00 -0000 [thread overview]
Message-ID: <55F91312.7050206@st.com> (raw)
In-Reply-To: <55F7E7F9.8000702@arm.com>
On 09/15/2015 11:42 AM, Kyrill Tkachov wrote:
> Hi Christian,
>
> On 14/09/15 10:05, Christian Bruel wrote:
>> Hi,
>>
>> Prior sending the remaining target attributes, I'd like to simplify a
>> few chunks (thinko) that were unnecessary complicated : The options
>> checks in arm_option_params_internal can't be from another context than
>> global_options.
>
> Hmmm... I agree. TARGET_SET_CURRENT_FUNCTION will restore
> the target options node into the global options and call
> arm_option_params_internal, which can assume it operates
> on the global options.
>
> This patch is ok but...
>
>>
>> Also add TARGET_OPTION_PRINT, small enough chunk to slip here I hope.
>
> Please split this out into a separate patch with a separate ChangeLog entry.
> Such a patch is pre-approved as long as the implementation of TARGET_OPTION_PRINT
> is the same as in this patch.
>
> Thanks,
> Kyrill
>
OK Committed @ resp r227794 and r227795
>>
>> Testing OK,
>>
>> Thanks
>>
>> Christian
>>
>
prev parent reply other threads:[~2015-09-16 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 9:06 Christian Bruel
2015-09-15 9:42 ` Kyrill Tkachov
2015-09-16 7:10 ` Christian Bruel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F91312.7050206@st.com \
--to=christian.bruel@st.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).