From: Nathan Sidwell <nathan@acm.org>
To: Jason Merrill <jason@redhat.com>,
Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [C++] Coding rule enforcement
Date: Wed, 16 Sep 2015 14:37:00 -0000 [thread overview]
Message-ID: <55F97E61.8000701@acm.org> (raw)
In-Reply-To: <55F97B68.9060500@redhat.com>
On 09/16/15 10:23, Jason Merrill wrote:
> On 09/16/2015 08:02 AM, Nathan Sidwell wrote:
>> + else if (warn_multiple_inheritance)
>> + warning (OPT_Wmultiple_inheritance,
>> + "%qT defined with multiple direct bases", ref);
>
> You don't need to guard the warning with a check of the warning flag; warning
> will only give the warning if the option is enabled.
hm, it didn't seem to be doing that. Perhaps I'd got something wrong ...looking
next prev parent reply other threads:[~2015-09-16 14:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 13:08 Nathan Sidwell
2015-09-15 13:28 ` Richard Biener
2015-09-15 13:33 ` Nathan Sidwell
2015-09-15 13:36 ` Jason Merrill
2015-09-16 12:10 ` Nathan Sidwell
2015-09-16 14:23 ` Jason Merrill
2015-09-16 14:37 ` Nathan Sidwell [this message]
2015-09-16 16:36 ` Manuel López-Ibáñez
2015-09-16 19:34 ` Bernhard Reutner-Fischer
2015-09-17 14:56 ` Nathan Sidwell
2015-09-15 17:20 ` Manuel López-Ibáñez
2015-09-15 18:33 ` Jason Merrill
2015-09-21 13:52 ` Daniel Gutson
2015-09-21 14:02 ` Manuel López-Ibáñez
2015-09-21 16:31 ` Jason Merrill
2015-09-21 16:42 ` Daniel Gutson
2015-09-21 16:57 ` Nathan Sidwell
2015-09-21 17:19 ` Jason Merrill
2015-09-17 14:58 Ville Voutilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F97E61.8000701@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).