From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34225 invoked by alias); 16 Sep 2015 15:29:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 34168 invoked by uid 89); 16 Sep 2015 15:29:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Sep 2015 15:29:29 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-37-Kh1_C4pXTfWQVstu1aRUyg-1; Wed, 16 Sep 2015 16:29:23 +0100 Received: from e105915-lin.cambridge.arm.com ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 16 Sep 2015 16:29:23 +0100 Subject: Re: [PATCH, rs6000] Add expansions for min/max vector reductions To: Bill Schmidt , "gcc-patches@gcc.gnu.org" References: <1442413689.2896.45.camel@gnopaine> Cc: "dje.gcc@gmail.com" From: Alan Lawrence Message-ID: <55F98AD2.4080408@arm.com> Date: Wed, 16 Sep 2015 15:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442413689.2896.45.camel@gnopaine> X-MC-Unique: Kh1_C4pXTfWQVstu1aRUyg-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg01196.txt.bz2 On 16/09/15 15:28, Bill Schmidt wrote: > 2015-09-16 Bill Schmidt > > * config/rs6000/altivec.md (UNSPEC_REDUC_SMAX, UNSPEC_REDUC_SMIN, > UNSPEC_REDUC_UMAX, UNSPEC_REDUC_UMIN, UNSPEC_REDUC_SMAX_SCAL, > UNSPEC_REDUC_SMIN_SCAL, UNSPEC_REDUC_UMAX_SCAL, > UNSPEC_REDUC_UMIN_SCAL): New enumerated constants. > (reduc_smax_v2di): New define_expand. > (reduc_smax_scal_v2di): Likewise. > (reduc_smin_v2di): Likewise. > (reduc_smin_scal_v2di): Likewise. > (reduc_umax_v2di): Likewise. > (reduc_umax_scal_v2di): Likewise. > (reduc_umin_v2di): Likewise. > (reduc_umin_scal_v2di): Likewise. > (reduc_smax_v4si): Likewise. > (reduc_smin_v4si): Likewise. > (reduc_umax_v4si): Likewise. > (reduc_umin_v4si): Likewise. > (reduc_smax_v8hi): Likewise. > (reduc_smin_v8hi): Likewise. > (reduc_umax_v8hi): Likewise. > (reduc_umin_v8hi): Likewise. > (reduc_smax_v16qi): Likewise. > (reduc_smin_v16qi): Likewise. > (reduc_umax_v16qi): Likewise. > (reduc_umin_v16qi): Likewise. > (reduc_smax_scal_): Likewise. > (reduc_smin_scal_): Likewise. > (reduc_umax_scal_): Likewise. > (reduc_umin_scal_): Likewise. You shouldn't need the non-_scal reductions. Indeed, they shouldn't be used= if=20 the _scal are present. The non-_scal's were previously defined as producing= a=20 vector with one element holding the result and the other elements all zero,= and=20 this was only ever used with a vec_extract immediately after; the _scal pat= tern=20 now includes the vec_extract as well. Hence the non-_scal patterns are=20 deprecated / considered legacy, as per md.texi. I proposed a patch to migrate PPC off the old patterns, but have forgotten = to=20 ping it recently - last at=20 https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01024.html ... (ping?!) --Alan