From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37548 invoked by alias); 16 Sep 2015 19:09:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 37474 invoked by uid 89); 16 Sep 2015 19:09:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Sep 2015 19:09:12 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 02DBB91C02; Wed, 16 Sep 2015 19:09:11 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-28.phx2.redhat.com [10.3.113.28]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8GJ9AIX000530; Wed, 16 Sep 2015 15:09:10 -0400 Subject: Re: [PATCH] Move check_global_declaration from toplev.c to cgraphunit.c To: =?UTF-8?B?TWFudWVsIEzDs3Blei1JYsOhw7Fleg==?= , Gcc Patch List , Jan Hubicka References: From: Jeff Law Message-ID: <55F9BE55.5090407@redhat.com> Date: Wed, 16 Sep 2015 19:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg01230.txt.bz2 On 09/16/2015 11:54 AM, Manuel López-Ibáñez wrote: > Unfortunately, toplev.c is a kitchen sink of things that do not belong > anywhere in particular. > For example, check_global_declarations is only used in cgraphunit.c. > Moving it there allows us to make it static and remove one call to > symtab_node::get. > > Bootstrapped & regtested on x86_64-linux-gnu. > > OK? > > gcc/ChangeLog: > > 2015-09-15 Manuel López-Ibáñez > > * toplev.h (check_global_declaration): Remove declaration. > * toplev.c (check_global_declaration): Move to ... > * cgraphunit.c: ... here. Make it static and pass a symtab_node *. > (analyze_functions): Update call. I'm not really sure that passing in the symtab node is better than the underlying decl. But I doubt it really matters in practice. Ok for the trunk. jeff