From: Bernd Schmidt <bschmidt@redhat.com>
To: Simon Dardis <Simon.Dardis@imgtec.com>, Jeff Law <law@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Target hook for disabling the delay slot filler.
Date: Thu, 17 Sep 2015 11:16:00 -0000 [thread overview]
Message-ID: <55FA92F4.7050505@redhat.com> (raw)
In-Reply-To: <B83211783F7A334B926F0C0CA42E32CAF2E5D8@hhmail02.hh.imgtec.org>
On 09/17/2015 11:52 AM, Simon Dardis wrote:
> The profitability of using an ordinary branch over a delay slot branch
> depends on how the delay slot is filled. If a delay slot can be filled from
> an instruction preceding the branch or instructions proceeding that must be
> executed on both sides then it is profitable to use a delay slot branch.
>
> For cases when instructions are chosen from one side of the branch,
> the proposed optimization strategy is to not speculatively execute
> instructions when ordinary branches could be used. Performance-wise
> this avoids executing instructions which the eager delay filler picked
> wrongly.
>
> Since most branches have a compact form disabling the eager delay filler
> should be no worse than altering it not to fill delay slots in this case.
Ok, so in that case I think the patch would be reasonable if the target
hook was named appropriately to say something like don't speculate when
filling delay slots. It looks like fill_eager_delay_slots always
speculates, so you needn't change your approach in reorg.c.
Possibly place the hook after rtx_cost/address_cost in target.def since
it's cost related.
Bernd
next prev parent reply other threads:[~2015-09-17 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 14:25 Simon Dardis
2015-09-15 14:34 ` Bernd Schmidt
2015-09-15 15:18 ` Jeff Law
2015-09-17 10:15 ` Simon Dardis
2015-09-17 11:16 ` Bernd Schmidt [this message]
2015-09-17 17:01 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FA92F4.7050505@redhat.com \
--to=bschmidt@redhat.com \
--cc=Simon.Dardis@imgtec.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).