From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86614 invoked by alias); 18 Sep 2015 13:51:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 86509 invoked by uid 89); 18 Sep 2015 13:51:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Sep 2015 13:51:22 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1Zcw4N-0000Is-0S from Cesar_Philippidis@mentor.com for gcc-patches@gcc.gnu.org; Fri, 18 Sep 2015 06:51:19 -0700 Received: from [127.0.0.1] (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.224.2; Fri, 18 Sep 2015 06:51:18 -0700 Subject: Re: [gomp4, wip] remove references to ganglocal shared memory inside gcc To: Thomas Schwinge References: <55DE69C3.4060707@codesourcery.com> <55E5D283.8080105@mentor.com> <87y4g415qi.fsf@kepler.schwinge.homeip.net> CC: Tom de Vries , "gcc-patches@gcc.gnu.org" , Nathan Sidwell From: Cesar Philippidis Message-ID: <55FC16D6.7050802@codesourcery.com> Date: Fri, 18 Sep 2015 13:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <87y4g415qi.fsf@kepler.schwinge.homeip.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg01413.txt.bz2 On 09/18/2015 01:39 AM, Thomas Schwinge wrote: > On Tue, 1 Sep 2015 18:29:55 +0200, Tom de Vries wrote: >> On 27/08/15 03:37, Cesar Philippidis wrote: >>> - ctx->ganglocal_size_host = align_and_expand (&gl_host, host_size, align); >> >> I suspect this caused a bootstrap failure (align_and_expand unused). >> Worked-around as attached. > >> --- a/gcc/omp-low.c >> +++ b/gcc/omp-low.c >> @@ -1450,7 +1450,7 @@ omp_copy_decl (tree var, copy_body_data *cb) >> >> /* Modify the old size *POLDSZ to align it up to ALIGN, and then return >> a value with SIZE added to it. */ >> -static tree >> +static tree ATTRIBUTE_UNUSED >> align_and_expand (tree *poldsz, tree size, unsigned int align) >> { >> tree oldsz = *poldsz; > > If I remember correctly, this has only ever been used in the "ganglocal" > implementation -- which is now gone. So, should align_and_expand also be > elided (Cesar)? Most likely. I probably overlooked it when I was working on that ganglocal removal patch. Can you remove it please? I'm already juggling a couple of patches right now. Thanks, Cesar