From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122471 invoked by alias); 18 Sep 2015 15:32:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 122453 invoked by uid 89); 18 Sep 2015 15:32:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Sep 2015 15:32:40 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 51259461C1; Fri, 18 Sep 2015 15:32:39 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-28.phx2.redhat.com [10.3.113.28]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8IFWciB023680; Fri, 18 Sep 2015 11:32:38 -0400 Subject: Re: (patch,rfc) s/gimple/gimple */ To: Trevor Saunders , David Malcolm References: <20150916131510.GA21102@tsaunders-iceball.corp.tor1.mozilla.com> <1442430674.32352.109.camel@surprise> <20150918133200.GA22271@tsaunders-iceball.corp.tor1.mozilla.com> Cc: gcc-patches@gcc.gnu.org From: Jeff Law Message-ID: <55FC2E95.4060504@redhat.com> Date: Fri, 18 Sep 2015 15:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150918133200.GA22271@tsaunders-iceball.corp.tor1.mozilla.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg01429.txt.bz2 On 09/18/2015 07:32 AM, Trevor Saunders wrote: > On Wed, Sep 16, 2015 at 03:11:14PM -0400, David Malcolm wrote: >> On Wed, 2015-09-16 at 09:16 -0400, Trevor Saunders wrote: >>> Hi, >>> >>> I gave changing from gimple to gimple * a shot last week. It turned out >>> to be not too hard. As you might expect the patch is huge so its >>> attached compressed. >>> >>> patch was bootstrapped + regtested on x86_64-linux-gnu, and run through >>> config-list.mk. However I needed to update it some for changes made >>> while testing. Do people want to make this change now? If so I'll try >>> and commit the patch over the weekend when less is changing. >> >> >> FWIW there are some big changes in gcc/tree-vect-slp.c:vectorizable_load >> that looks like unrelated whitespace changes, e.g. the following (and >> there are some followup hunks). Did something change underneath, or was >> there a stray whitespace cleanup here? (I skimmed through the patch, >> and this was the only file I spotted where something looked wrong) > > yeah, it was a stray whitespace cleanup, but I reverted it. > > Given the few but only positive comments I've seen I'm planning to > commit this over the weekend. That works for me. jeff