From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129099 invoked by alias); 21 Sep 2015 10:56:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129031 invoked by uid 89); 21 Sep 2015 10:55:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mx07-00178001.pphosted.com Received: from mx07-00178001.pphosted.com (HELO mx07-00178001.pphosted.com) (62.209.51.94) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Sep 2015 10:55:58 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by m0046037.ppops.net (8.14.5/8.14.5) with SMTP id t8LAreFL009959; Mon, 21 Sep 2015 12:55:50 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by m0046037.ppops.net with ESMTP id 1x16dnh1jt-1 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 21 Sep 2015 12:55:50 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1FBB231; Mon, 21 Sep 2015 10:55:34 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas4.st.com [10.75.90.69]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B551C51C9; Mon, 21 Sep 2015 10:55:48 +0000 (GMT) Received: from [164.129.122.197] (164.129.122.197) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.342.0; Mon, 21 Sep 2015 12:55:48 +0200 Subject: Re: [PATCH, ARM]: Fix static interworking call To: Christophe Lyon , Richard Earnshaw References: <55FA7DD9.8090108@st.com> <55FC1CD2.10207@foss.arm.com> <55FC21D0.909@st.com> <55FC27C8.7050503@foss.arm.com> CC: "kyrylo.tkachov@arm.com" , "Ramana.Radhakrishnan@arm.com" , "gcc-patches@gcc.gnu.org" From: Christian Bruel X-No-Archive: yes Message-ID: <55FFE233.5030803@st.com> Date: Mon, 21 Sep 2015 10:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-09-21_05:2015-09-21,2015-09-21,1970-01-01 signatures=0 X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg01536.txt.bz2 Hi Christophe, > It seems you committed the 1st version of your patch. Not sure what version you are talking about. I committed what was posted (https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01260.html) at revision #227880. > However, it fails if one forces a armv5t target, because, as Richard > said -mfloat-abi=hard is not supported on Thumb1. sure, but the testcase was for thumb2. It's just that the thumb1 check in the dg-skip-if is indeed useless. I'll fix this. > > It tried to remove -mfloat-abi=hard, and I noticed that only 1 'blx' > is generated when using soft or softfp. > > I expect this to be fixed by the linker anyway, but it may mean there > is still something wrong. This is expected. For thumb1, such static calls interwork are still done by the linker. For consistency IMHO we could also resolve static interwork thumb1 calls in the compiler, but that would be another issue. This failure was only for thumb2 (this having -march=armv7-a in the dg-options). (See https://sourceware.org/bugzilla/show_bug.cgi?id=17505) Hope that clarifies, thanks Christian