From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81206 invoked by alias); 27 Jul 2017 09:09:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108609 invoked by uid 89); 27 Jul 2017 09:07:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=works!, educated, HTo:D*comcast.net, heard X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jul 2017 09:07:53 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id D885E8136C; Thu, 27 Jul 2017 11:07:51 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q5MGIYY2MXoF; Thu, 27 Jul 2017 11:07:51 +0200 (CEST) Received: from [IPv6:2a02:2ab8:224:1:f21f:afff:fe4c:b838] (cacatoes.act-europe.fr [IPv6:2a02:2ab8:224:1:f21f:afff:fe4c:b838]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id AEC93812E7; Thu, 27 Jul 2017 11:07:51 +0200 (CEST) Subject: Re: [PATCH 0/2] Python testcases to check DWARF output To: Richard Biener , Mike Stump Cc: GCC Patches References: <20170726160040.6516-1-derodat@adacore.com> <8EF1EAAC-B956-4214-A707-EE692659F428@comcast.net> From: Pierre-Marie de Rodat Message-ID: <55c21fe5-da33-74d7-fe42-c6735fd50e26@adacore.com> Date: Thu, 27 Jul 2017 09:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg01786.txt.bz2 Thank you for your feedback. On 07/27/2017 09:52 AM, Richard Biener wrote: >> I'm fine with the direction if a reviewer wants to go in that >> direction. I wish python didn't have a built-in speed penalty, >> that's the only downside I don't like about it. Aside from that, >> even switching all of the testsuite to be python based isn't a >> terrible idea. > > But is it worse than TCL? Good point. Actually for Python there are ways to make it faster. If we can somehow manage to have a limited set of Python interpreter instances (instead of one per test), we could use pypy, which is very good I heard to make long running instances fast. As to switch all of the testsuite to Python, I don’t have an educated opinion on this. I just want to say that, here I’m using Python to pattern match DIEs, but if needed we could perfectly use it to do other complex tasks. This is why I kept the DWARF-specific stuff (gcc-dwarf.exp and the dwarfutils Python package, from second commit) separate from just Python interpreter handling (gcc-python.exp, from first commit). Note that having a Python only testsuite would make it easier to have only one Python instance for all the testsuite run, so it would, in theory, make it easier to get a fast execution. … now, I’m not familiar with DejaGNU but I have the feeling that it does a lot with respect to the handling of a great variety of targets/remote/etc. combinations. Re-writing it (and making sure it works!) sounds like a huuuge task. I’ll let experts in this area comment. :-) -- Pierre-Marie de Rodat