From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B4F6A3850210 for ; Mon, 13 Jun 2022 18:25:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B4F6A3850210 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-21-a3Mt1Ro5OD2S33sMQtAokw-1; Mon, 13 Jun 2022 14:25:16 -0400 X-MC-Unique: a3Mt1Ro5OD2S33sMQtAokw-1 Received: by mail-qt1-f199.google.com with SMTP id z20-20020a05622a061400b00305336a6cbbso2767222qta.12 for ; Mon, 13 Jun 2022 11:25:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=KP4r8YFXP5jdz47WT7zF75N3SsJI+s1uQrSS1a+gkeE=; b=s3cDiuzK3x0G/k7zuqamVi5L0PkvEIwza/2pTZLhXa6bTZb6iB8SterCtkMVCdHAwS Sl6DMCwMF6MYJ1Ls7srCay/WcU7TcIzAMAHmLyEUgyoziZ9VJRxaB+yXrRwRuzyeGcaZ W95nKJTOyX4Nt2C111Y7vx0pkjRw0/rpab1o7FA2pcXw00Oi9WCYo9cbDA+zpMg7AZZe ihkFZoMMtyWukeFBHpHdtVmuSzWoZthu4xXRA7NqiGYW2AVhc/rZw+ODcpp+qYbNV7yf nPveDlyica0fGxVqmrROKsRTm9Lv46HzRwNS3TT8I6cZfblJZNuDqaYn7vz3LBZT5OLS W/UA== X-Gm-Message-State: AJIora9iuq3FMa0DjecE0Lrxmg3ip8phlBJNcDAMD+Nk4W45Cimmhd5W LLp6EW8oc/BEaIWkFRWJhJS1DpiZBGw4uz2aOi0CkhMrmbyoy2GnXvmTrGe5fUFBnZaXbOWcB1+ 5R+lT5eHF3NbhK/XpoK4a0TsDhE9pFlSKDeNu6VTDHhVAiYStytiQrO0XryRYY7cmrgolyQ== X-Received: by 2002:a0c:f88f:0:b0:46b:8c17:bd18 with SMTP id u15-20020a0cf88f000000b0046b8c17bd18mr345289qvn.9.1655144715694; Mon, 13 Jun 2022 11:25:15 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uePWgIvMp1Xc885oqzfe5Pv7NEhtyVpsQC26tkZqxfU6Z4NpBE/BrE5mgI8O6j1pj23CUxXw== X-Received: by 2002:a0c:f88f:0:b0:46b:8c17:bd18 with SMTP id u15-20020a0cf88f000000b0046b8c17bd18mr345269qvn.9.1655144715392; Mon, 13 Jun 2022 11:25:15 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id h16-20020ac87d50000000b003051e3b49c2sm5511277qtb.61.2022.06.13.11.25.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 11:25:14 -0700 (PDT) Message-ID: <55c38eed09f7896673e3c6ba8bd6d63405174c6d.camel@redhat.com> Subject: PING: Re: [PATCH 03/10] expr.cc: use final/override on op_by_pieces_d vfuncs From: David Malcolm To: gcc-patches@gcc.gnu.org Date: Mon, 13 Jun 2022 14:25:13 -0400 In-Reply-To: <20220523192834.3785673-4-dmalcolm@redhat.com> References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-4-dmalcolm@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 18:25:20 -0000 Ping on this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595434.html OK for trunk? Thanks Dave On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > gcc/ChangeLog: >         * expr.cc: Add "final" and "override" to op_by_pieces_d vfunc >         implementations as appropriate. > > Signed-off-by: David Malcolm > --- >  gcc/expr.cc | 14 +++++++------- >  1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/gcc/expr.cc b/gcc/expr.cc > index 7197996cec7..ce58728862a 100644 > --- a/gcc/expr.cc > +++ b/gcc/expr.cc > @@ -1357,8 +1357,8 @@ op_by_pieces_d::run () >  class move_by_pieces_d : public op_by_pieces_d >  { >    insn_gen_fn m_gen_fun; > -  void generate (rtx, rtx, machine_mode); > -  bool prepare_mode (machine_mode, unsigned int); > +  void generate (rtx, rtx, machine_mode) final override; > +  bool prepare_mode (machine_mode, unsigned int) final override; >   >   public: >    move_by_pieces_d (rtx to, rtx from, unsigned HOST_WIDE_INT len, > @@ -1453,8 +1453,8 @@ move_by_pieces (rtx to, rtx from, unsigned > HOST_WIDE_INT len, >  class store_by_pieces_d : public op_by_pieces_d >  { >    insn_gen_fn m_gen_fun; > -  void generate (rtx, rtx, machine_mode); > -  bool prepare_mode (machine_mode, unsigned int); > +  void generate (rtx, rtx, machine_mode) final override; > +  bool prepare_mode (machine_mode, unsigned int) final override; >   >   public: >    store_by_pieces_d (rtx to, by_pieces_constfn cfn, void *cfn_data, > @@ -1650,9 +1650,9 @@ class compare_by_pieces_d : public op_by_pieces_d >    rtx m_accumulator; >    int m_count, m_batch; >   > -  void generate (rtx, rtx, machine_mode); > -  bool prepare_mode (machine_mode, unsigned int); > -  void finish_mode (machine_mode); > +  void generate (rtx, rtx, machine_mode) final override; > +  bool prepare_mode (machine_mode, unsigned int) final override; > +  void finish_mode (machine_mode) final override; >   public: >    compare_by_pieces_d (rtx op0, rtx op1, by_pieces_constfn op1_cfn, >                        void *op1_cfn_data, HOST_WIDE_INT len, int > align,