From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70364 invoked by alias); 25 Sep 2015 16:58:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70334 invoked by uid 89); 25 Sep 2015 16:58:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 25 Sep 2015 16:58:09 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1CCE3ABBC3 for ; Fri, 25 Sep 2015 16:58:08 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-35.phx2.redhat.com [10.3.113.35]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8PGqbxo030539; Fri, 25 Sep 2015 12:52:37 -0400 Subject: Re: [PATCH 1/5] Testsuite: add dg-{begin|end}-multiline-output commands To: David Malcolm , gcc-patches@gcc.gnu.org References: <1442957171-22904-1-git-send-email-dmalcolm@redhat.com> <1442957171-22904-2-git-send-email-dmalcolm@redhat.com> From: Jeff Law Message-ID: <56057BD5.2010001@redhat.com> Date: Fri, 25 Sep 2015 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442957171-22904-2-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg02002.txt.bz2 On 09/22/2015 03:26 PM, David Malcolm wrote: > This patch is essentially identical to v1 here: > https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00729.html > The only change is in the ChangeLog, moving the libgo.exp > ChangeLog entry into gcc/testsuite/ChangeLog, analogous to > where Ian put it when introducing the file in r167407. > > OK for trunk? > > Blurb from v1 follows: > > This patch adds an easy way to write tests for expected multiline > output. For example we can test carets and underlines for > a particular diagnostic with: > > /* { dg-begin-multiline-output "" } > typedef struct _GMutex GMutex; > ^~~~~~~ > { dg-end-multiline-output "" } */ > > It is used extensively by the rest of the patch kit. > > multiline.exp is used by prune.exp; hence we need to load it before > prune.exp via *load_gcc_lib* for the testsuites of the various > non-"gcc" support libraries (e.g. boehm-gc). > > gcc/testsuite/ChangeLog: > * lib/multiline.exp: New file. > * lib/prune.exp: Load multiline.exp. > (prune_gcc_output): Call into multiline.exp to handle any > multiline output directives. > * lib/libgo.exp: Load multiline.exp before prune.exp, using > load_gcc_lib. > > boehm-gc/ChangeLog: > * testsuite/lib/boehm-gc.exp: Load multiline.exp before > prune.exp, using load_gcc_lib. > > libatomic/ChangeLog: > * testsuite/lib/libatomic.exp: Load multiline.exp before > prune.exp, using load_gcc_lib. > > libgomp/ChangeLog: > * testsuite/lib/libgomp.exp: Load multiline.exp before prune.exp, > using load_gcc_lib. > > libitm/ChangeLog: > * testsuite/lib/libitm.exp: Load multiline.exp before prune.exp, > using load_gcc_lib. > > libvtv/ChangeLog: > * testsuite/lib/libvtv.exp: Load multiline.exp before prune.exp, > using load_gcc_lib. This stalled due to the dejagnu version discussion, which itself has stalled :( I think the only issue was the loading of prune.exp and until we've jumped to the latest dejagnu, using load_gcc_lib is the approved way to deal with that problem. Soooo. Approved. Hopefully we'll be able to clean up the load_gcc_lib mess in the near future, but I don't see a good reason to continue to hold up this patch. jeff