From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93651 invoked by alias); 26 Sep 2015 13:34:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 93633 invoked by uid 89); 26 Sep 2015 13:34:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp24.services.sfr.fr Received: from smtp24.services.sfr.fr (HELO smtp24.services.sfr.fr) (93.17.128.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 26 Sep 2015 13:34:27 +0000 Received: from filter.sfr.fr (localhost [86.72.15.16]) by msfrf2403.sfr.fr (SMTP Server) with ESMTP id 8C8A17000072; Sat, 26 Sep 2015 15:34:24 +0200 (CEST) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header.from=mikael.morin@sfr.fr Received: from [192.168.1.85] (16.15.72.86.rev.sfr.net [86.72.15.16]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by msfrf2403.sfr.fr (SMTP Server) with ESMTP id 0C79470000B9; Sat, 26 Sep 2015 15:34:23 +0200 (CEST) X-SFR-UUID: 20150926133424512.0C79470000B9@msfrf2403.sfr.fr Subject: Re: [PATCH] fortran/67616 -- Fix ICE within a BLOCK construct To: Steve Kargl , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <20150925214129.GA19593@troutmask.apl.washington.edu> From: Mikael Morin Message-ID: <56069EDE.2000409@sfr.fr> Date: Sat, 26 Sep 2015 19:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150925214129.GA19593@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg02054.txt.bz2 Le 25/09/2015 23:41, Steve Kargl a écrit : > The attached patch has been built and regression > tested on x86_64-*-freebsd. No regression occurred. > > The patch removes a conditional within an assert() > that triggers when a BLOCK construct is encountered. > What happens here, I think, is symtree is a new block-local symbol instead of the host-associated one. symtree is basically unused here, yet playing with the wrong one is not right. Can you try using gfc_get_ha_sym_tree a few lines above instead of gfc_get_sym_tree? A patch like that is preapproved. Mikael