From: Daniel Hellstrom <daniel@gaisler.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: gcc-patches@gcc.gnu.org, ebotcazou@adacore.com,
rtems-devel@rtems.org, software@gaisler.com
Subject: Re: [PATCH] Update RTEMS multilib for SPARC
Date: Mon, 28 Sep 2015 15:41:00 -0000 [thread overview]
Message-ID: <56095661.9010208@gaisler.com> (raw)
In-Reply-To: <5609454E.6080608@embedded-brains.de>
On 09/28/2015 03:49 PM, Sebastian Huber wrote:
>
>
> On 28/09/15 15:39, Daniel Hellstrom wrote:
>> On 09/28/2015 03:37 PM, Sebastian Huber wrote:
>>>
>>>
>>> On 28/09/15 15:20, Daniel Hellstrom wrote:
>>>>> Which multilibs do we have after this change?
>>>>
>>>> .;
>>>> soft;@msoft-float
>>>> v8;@mcpu=v8
>>>> leon3;@mcpu=leon3
>>>> leon3v7;@mcpu=leon3v7
>>>> leon;@mcpu=leon
>>>> leon/ut699;@mcpu=leon@mfix-ut699
>>>> leon/at697f;@mcpu=leon@mfix-at697f
>>>> soft/v8;@msoft-float@mcpu=v8
>>>> soft/leon3;@msoft-float@mcpu=leon3
>>>> soft/leon3v7;@msoft-float@mcpu=leon3v7
>>>> soft/leon;@msoft-float@mcpu=leon
>>>> soft/leon/ut699;@msoft-float@mcpu=leon@mfix-ut699
>>>> soft/leon/at697f;@msoft-float@mcpu=leon@mfix-at697f
>>>
>>> Ok, looks good. The change log entry should mention that you add -mcpu=leon multilibs as well.
>>
>> Ooh I forgot to mention that, I will add it to the comment. Otherwise is this okay to commit for 4.9, 5 and master now?
>
> Since this is a RTEMS only change, I think this is all right. Just make sure the change log entry format is all right. The statements end all with a '.' for example.
Thanks for the review, updated the comments and committed it.
Daniel
prev parent reply other threads:[~2015-09-28 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 12:36 Daniel Hellstrom
2015-09-28 13:02 ` Sebastian Huber
2015-09-28 13:45 ` Sebastian Huber
2015-09-28 13:49 ` Daniel Hellstrom
2015-09-28 14:03 ` Sebastian Huber
2015-09-28 14:24 ` Daniel Hellstrom
2015-09-28 14:43 ` Sebastian Huber
2015-09-28 15:41 ` Daniel Hellstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56095661.9010208@gaisler.com \
--to=daniel@gaisler.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rtems-devel@rtems.org \
--cc=sebastian.huber@embedded-brains.de \
--cc=software@gaisler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).