On 09/29/2015 12:11 PM, Trevor Saunders wrote:
> On Tue, Sep 29, 2015 at 10:55:46AM -0600, Jeff Law wrote:
>> The pdp11 port fails to build with the trunk because of a warning.
>> Essentially VRP determines that the result of using BRANCH_COST is a
>> constant with the range [0..1].  That's always less than 4, 3 and the
>> various other magic constants used with BRANCH_COST and VRP issues a warning
>> about that comparison.
>>
>> I expect we're going to be overhauling BRANCH_COST shortly.  In the mean
>> time, this just revectors BRANCH_COST for the pdp11 into a function to
>> prevent VRP from collapsing the test and issuing the warning.
>>
>> Yes, this means more code in the pdp11 cross compiler.  I'm not terribly
>> concerned about that and I couldn't stand the idea of scattering diagnostic
>> push/pop stuff all over the place to make just the pdp11 port happy.
>
> ENOPATCH, but it seems like that's the right direction anyway since it
> makes it slightly easier to convert the macro to a hook ;)
Bah.  Attached this time :-)

Yea, hookization was in the back of my mind when I made the final choice 
to use a function call.

Jeff