From: Nathan Sidwell <nathan@acm.org>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Bernd Schmidt <bschmidt@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: Fold acc_on_device
Date: Wed, 30 Sep 2015 12:40:00 -0000 [thread overview]
Message-ID: <560BD31C.9020503@acm.org> (raw)
In-Reply-To: <CAFiYyc1vH1nXqtb6C99+rXozyJ5tyV876cLr=NeuB8oC8=3V_g@mail.gmail.com>
On 09/30/15 04:07, Richard Biener wrote:
> On Tue, Sep 29, 2015 at 8:21 PM, Nathan Sidwell <nathan@acm.org> wrote:
>> This patch folds acc_on_device as a regular builtin, but postponed until we
>> know which compiler we're in. As suggested by Bernd, we use the existing
>> builtin folding machinery.
>>
>> Trunk is still using the older PTX runtime scheme (Thomas is working on
>> that), so the only change there is in the host-side libgomp piece.
>>
>> Ok for trunk?
>
> Please don't add any new GENERIC based builtin folders. Instead add to
> gimple-fold.c:gimple_fold_builtin
>
> Otherwise you're just generating more work for us who move foldings from
> builtins.c to gimple-fold.c.
Oh, sorry, I didn't know about that. Will fix.
Should I use the same
if (symtab->state == EXPANSION)
test to make sure we're after LTO read back (i.e. know which compiler we're in),
or is there another way?
nathan
next prev parent reply other threads:[~2015-09-30 12:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 18:50 Nathan Sidwell
2015-09-29 20:22 ` Bernd Schmidt
2015-09-29 20:29 ` Nathan Sidwell
2015-09-30 8:55 ` Richard Biener
2015-09-30 12:40 ` Nathan Sidwell [this message]
2015-09-30 12:40 ` Bernd Schmidt
2015-09-30 12:57 ` Richard Biener
2015-09-30 14:17 ` Nathan Sidwell
2015-09-30 19:23 ` Nathan Sidwell
2015-09-30 20:00 ` Jakub Jelinek
2015-10-01 10:03 ` Richard Biener
2015-10-01 12:33 ` Nathan Sidwell
2015-10-01 12:46 ` Richard Biener
2015-10-01 14:14 ` Nathan Sidwell
2015-10-06 6:13 ` Segher Boessenkool
2015-10-06 14:04 ` Nathan Sidwell
2015-10-01 17:00 ` Andrew MacLeod
2015-10-01 17:11 ` Nathan Sidwell
2015-10-01 21:08 ` Andrew MacLeod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560BD31C.9020503@acm.org \
--to=nathan@acm.org \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).