From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102546 invoked by alias); 30 Sep 2015 13:47:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102537 invoked by uid 89); 30 Sep 2015 13:47:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Sep 2015 13:47:40 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 9C15EAEF0F; Wed, 30 Sep 2015 13:47:39 +0000 (UTC) Received: from localhost.localdomain (vpn1-5-139.ams2.redhat.com [10.36.5.139]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8UDlbpT013950; Wed, 30 Sep 2015 09:47:37 -0400 Subject: Re: [PATCH] Fix default_binds_local_p_2 for extern protected data To: Szabolcs Nagy , "gcc-patches@gcc.gnu.org" References: <55AFCC7C.8010105@arm.com> <55C8854D.5060609@arm.com> <55FA84C1.6010603@arm.com> Cc: Marcus Shawcroft , Ramana Radhakrishnan , Andreas Krebbel , "H.J. Lu" , Jakub Jelinek , Richard Henderson From: Bernd Schmidt Message-ID: <560BE7F9.1010708@redhat.com> Date: Wed, 30 Sep 2015 15:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55FA84C1.6010603@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg02352.txt.bz2 On 09/17/2015 11:15 AM, Szabolcs Nagy wrote: > ping 2. > > this patch is needed for working visibility ("protected") > attribute for extern data on targets using default_binds_local_p_2. > https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01871.html I hesitate to review this one since I don't think I understand the issues on the various affected arches well enough. It looks like Jakub had some input on the earlier changes, maybe he could take a look? Or maybe rth knows best. Adding Ccs. It would help to have examples of code generation demonstrating the problem and how you would solve it. Input from the s390 maintainers whether this is correct for their port would also be appreciated. >>> Needs a further binutils patch too to emit R_*_GLOB_DAT >>> instead of R_*_RELATIVE relocs for protected data. >>> The glibc elf/tst-protected1a and elf/tst-protected1b >>> tests depend on this. What is the consequence of not having this binutils patch? Is the gcc patch and improvement, a null, or are there situations where it causes regressions without the binutils patch? >>> Tested ARM and AArch64 targets. Tested how, with or without this binutils patch? Bernd