From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53622 invoked by alias); 30 Sep 2015 19:02:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53608 invoked by uid 89); 30 Sep 2015 19:02:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Sep 2015 19:02:40 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id EAC4DC0B2E07; Wed, 30 Sep 2015 19:02:38 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-59.phx2.redhat.com [10.3.113.59]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8UJ2bUe026186; Wed, 30 Sep 2015 15:02:37 -0400 Subject: Re: [PATCH ARM]: PR67745: Fix function alignment after __attribute__ 2/2 To: Christian Bruel References: <560A90F2.5010708@st.com> Cc: gcc-patches@gcc.gnu.org, kyrylo.tkachov@arm.com, richard.earnshaw@arm.com From: Jeff Law Message-ID: <560C31CD.7060009@redhat.com> Date: Wed, 30 Sep 2015 19:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <560A90F2.5010708@st.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg02388.txt.bz2 On 09/29/2015 07:24 AM, Christian Bruel wrote: > This patch uses FUNCTION_BOUNDARY instead of DECL_ALIGN to check the max > align when optimizing for size in assemble_start_function. > This is necessary for ARM that can switch the max code alignment > directives between modes. > > No regressions for ARM > Testing on-going for x86 > > Christian > > > align2.patch > > > 2015-09-29 Christian Bruel > > PR target/67745 > * gcc/varasm.c (assemble_start_function): Use current's function align. Does this override alignment information that might be attached to the DECL? Does that, in effect, override any alignment information that the developer may have put on the decl? If so, then it seems like a bad idea, even with -Os. Am I missing something here? jeff