From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62254 invoked by alias); 1 Oct 2015 21:08:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 62245 invoked by uid 89); 1 Oct 2015 21:08:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 01 Oct 2015 21:08:17 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 05E48AC1A1 for ; Thu, 1 Oct 2015 21:08:16 +0000 (UTC) Received: from [10.10.58.192] (vpn-58-192.rdu2.redhat.com [10.10.58.192]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t91L8FTM012676 for ; Thu, 1 Oct 2015 17:08:15 -0400 Subject: Re: Fold acc_on_device To: gcc-patches@gcc.gnu.org References: <560AD6A6.4050109@acm.org> <560BD31C.9020503@acm.org> <560D669B.6030709@redhat.com> <560D692C.4090101@acm.org> From: Andrew MacLeod Message-ID: <560DA0BE.8040102@redhat.com> Date: Thu, 01 Oct 2015 21:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <560D692C.4090101@acm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00134.txt.bz2 On 10/01/2015 01:11 PM, Nathan Sidwell wrote: > On 10/01/15 13:00, Andrew MacLeod wrote: > >> btw, not that it's necessarily important, but I'm about to submit the >> include >> reduction patches today, and it turns out this line is the first use of >> anything from cgraph.h in builtins.c. >> >> So if this is "the way" of doing the test, be aware it adds a >> dependency on >> cgraph.h that wasn't there before. > > The patch I just committed has moved this to gimple-fold.c. That > appears to already include cgraph.h. > > And it does indeed remove the need for cgraph.h in builtins.c. Andrew